Rename testdata.yaml to test_group.yaml and implement Test Case Configuration #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpsijm
changed the title
mzuenni
reviewed
Aug 14, 2025
mzuenni
reviewed
Aug 14, 2025
mzuenni
reviewed
Aug 14, 2025
|
Looks good to me just added 3 remarks |
Also took the time to replace some occurrences of test{case,group,node} with test{ ,_}{case,group,node}.
Verified by grepping `(?<![Cc]heck)testdata` that the phrase "testdata" no longer occurs, except in upgrade.py.
mpsijm
force-pushed
the
test-case-yamls
branch
from
7168ad9 to
e0d9c67
Compare
|
Thanks for the comments, I fixed them 😄 |
mzuenni
reviewed
Aug 15, 2025
mpsijm
force-pushed
the
test-case-yamls
branch
2 times, most recently
from
7db920b to
d5b35c4
Compare
mzuenni
reviewed
Aug 17, 2025
mzuenni
reviewed
Aug 17, 2025
mpsijm
force-pushed
the
test-case-yamls
branch
from
d5b35c4 to
9f53e63
Compare
|
Everything looks good to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
testdata.yamltotest_group.yaml(as defined here) and introduces Test Case Configuration .yaml files (as defined here).Additionally,
.hintand.descfiles are no longer used: they should now be keys (hint:anddescription:, respectively) in the Test Case Configuration file.A lot has changed, and I think everything still works, but please verify 😇
bt upgradeshould also properly take care of both migrations, both indata/and ingenerators.yaml.A special request for @thorehusfeldt if you have the time (if not, also fine 🙂): can you double-check the schemas for
test_group.yamland<testcase>.yamlwith the latest version of the spec? 😄