fix(iOS): Fix crash when localPort or connectedPort is null #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Rapsssito, could you please explain why this was closed? |
|
@landabaso, sorry for closing this without any explanation. I have added my review. |
Rapsssito
requested changes
Apr 24, 2025
Comment on lines
-140
to
-142
| } else { | ||
| // Default certificates | ||
| [settings setObject:_host forKey:(NSString *)kCFStreamSSLPeerName]; |
There was a problem hiding this comment.
Why should the default certificates be removed?
Comment on lines
+188
to
+189
| if([socket localHost] != nil && [socket connectedHost] != nil && [socket localPort] != nil | ||
| && [socket connectedPort] != nil) { |
There was a problem hiding this comment.
This fixes #197, but what is the reason behind these properties being nil?
Comment on lines
+205
to
+207
| NSString *msg = | ||
| [NSString stringWithFormat:@"no client found with id %@", client.id]; | ||
| [self sendEventWithName:@"error" body:@{@"id" : client.id, @"error" : msg}]; |
There was a problem hiding this comment.
Is this the correct error message?
Rapsssito
changed the title
Rapsssito
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will send an error event when connectedPort or localPort is null