Skip to content

[MOD-9576] Fix memory safety in cosine preprocessing #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 27, 2025

ש

d529f5e
Select commit
Loading
Failed to load commit list.
Merged

[MOD-9576] Fix memory safety in cosine preprocessing #670

ש
d529f5e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 27, 2025 in 0s

96.29% (+0.05%) compared to fbff84f

View this Pull Request on Codecov

96.29% (+0.05%) compared to fbff84f

Details

Codecov Report

Attention: Patch coverage is 89.36170% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.29%. Comparing base (fbff84f) to head (d529f5e).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
.../VecSim/spaces/computer/preprocessor_container.cpp 75.00% 2 Missing ⚠️
src/VecSim/spaces/computer/preprocessors.h 89.47% 2 Missing ⚠️
...rc/VecSim/spaces/computer/preprocessor_container.h 90.90% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #670      +/-   ##
==========================================
+ Coverage   96.24%   96.29%   +0.05%     
==========================================
  Files         112      111       -1     
  Lines        6278     6288      +10     
==========================================
+ Hits         6042     6055      +13     
+ Misses        236      233       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov