WIP/Open for Feedback: Connection Error Tracking & Auto-Reconnect #320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces connection error tracking and a configurable auto-reconnect mechanism to
memtier_benchmark
. The goal is to make benchmarks more resilient when running against clusters where TLS errors, timeouts, or dropped connections can otherwise abort runs prematurely.Key Features
Connection error tracking
Connection Errors
andConnection Errors/sec
).New options for reconnection
--reconnect-on-error
→ enable automatic reconnection when errors occur.--max-reconnect-attempts=N
→ limit reconnection retries (default: 3).--reconnect-backoff-factor=F
→ exponential backoff multiplier (default: 2.0).--connection-timeout=SECS
→ timeout before considering a connection attempt failed (default: 10s).Client behavior
BEV_EVENT_ERROR
,BEV_EVENT_EOF
, or timeout → update error stats, attempt reconnection (if enabled).Motivation
Large-scale TLS benchmarks (esp. with pipelines & high concurrency) often hit intermittent
EOF
orunexpected EOF while reading
. Previously, these failures could skew results or abort runs. With this change:Open Questions / Discussion
--reconnect-on-error
be enabled by default in CI/benchmarks, or stay opt-in?"connections"
block?Next Steps