Introduce FreeBSD CI #142
Open
Introduce FreeBSD CI #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
LecrisUT
suggested changes
Jul 31, 2025
arrowd
force-pushed
the
freebsd-ci
branch
4 times, most recently
from
89a29b5 to
ddf41bf
Compare
|
Can we get this in? |
LecrisUT
approved these changes
Aug 15, 2025
There was a problem hiding this comment.
LGTM, but I am not a maintainer. @langou is the one who usually merged my PRs, but I do not want to over-burden any single maintainer. If it's possible to know something about the communication channels and/or schedules of people, it will help us avoid pings.
@arrowd could you resolve the open comments (only authors and collaborators can do that). It would also be nice if the steps can be separated either as different GH actions steps or with echo "::group::" 1, and if the ctests could be run even if they are failing. These can be addressed in a separate PR though.
Footnotes
arrowd
force-pushed
the
freebsd-ci
branch
2 times, most recently
from
c55d4b0 to
f41a0c6
Compare
LecrisUT
reviewed
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are not run at the moment because they cause the job to hang (or are they take so much time?)
This will be investigated later.