Skip to content

Update rolify.rb #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update rolify.rb #458

wants to merge 1 commit into from

Conversation

alirezarahmani
Copy link

add table name to handle nested namespace problem

@coveralls
Copy link

coveralls commented Jul 25, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 93.047% when pulling 840cfe0 on alirezarahmani:master into 7ed33cb on RolifyCommunity:master.

laertispappas
laertispappas reviewed Oct 7, 2017
View reviewed changes
Copy link

@laertispappas laertispappas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to back this up with a test?

EppO
EppO requested changes Nov 18, 2017
View reviewed changes
Copy link
Member

@EppO EppO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test to cover this conditional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO EppO requested changes

+1 more reviewer

@laertispappas laertispappas laertispappas left review comments

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alirezarahmani @coveralls @EppO @laertispappas