feat(terminal): disable VS Code terminal shell integration by default

[roomote]

Set terminal shell integration disabled by default across the extension.\n\nChanges:\n- Default tool state routes commands via execa unless explicitly enabled in settings (see src/core/tools/executeCommandTool.ts, TypeScript.executeCommand()).\n- Provider initializes Terminal with disabled-by-default (see src/core/webview/ClineProvider.ts).\n- Webview-posted state defaults to disabled when unset (see src/core/webview/ClineProvider.ts, TypeScript.getState()).\n\nNotes:\n- Existing users with an explicit setting are respected.\n- All tests pass locally.

---

Important

Default terminal shell integration is now disabled, routing commands via execa unless explicitly enabled, affecting command execution and webview state initialization.

• Behavior:
  • Default terminal shell integration is now disabled, routing commands via execa unless explicitly enabled in settings (executeCommandTool() and executeCommand() in executeCommandTool.ts).
  • ClineProvider initializes terminal with shell integration disabled by default (ClineProvider.ts).
  • Webview state defaults to shell integration disabled when unset (ClineProvider.ts).
• Notes:
  • Existing user settings that explicitly enable shell integration are respected.
  • All tests pass locally.

^{This description was created by for e74c3a5. You can customize this summary. It will automatically update as commits are pushed.}

[roomote]

Self-review initiated: evaluating my own defaults like a recursive function waiting for a base case.

[roomote]

[P2] Default duplicated in multiple locations. The default true for terminalShellIntegrationDisabled is set here, in getStateToPostToWebview(), and in executeCommandTool (provider getState destructure and executeCommand param default). This scatters the source of truth and risks drift if one site changes. Consider introducing a single shared constant (e.g., DEFAULT_SHELL_INTEGRATION_DISABLED) in a common module and referencing it in all call sites to keep behavior consistent.

[roomote]

[P3] Same default hardcoded here as elsewhere. To avoid future divergence between webview state, provider initialization, and execution path selection (execa vs vscode), consider centralizing the default into a shared constant and importing it here.

[dreness]

Hi :) Can anyone summarize the rationale for this change? I don't object or anything, just curious. Cheers!