forked from cline/cline
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat: add thinking/reasoning data support to LiteLLM provider #8498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
roomote
wants to merge
1
commit into
main
Choose a base branch
from
feat/litellm-thinking-data
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -142,11 +142,34 @@ export class LiteLLMHandler extends RouterProvider implements SingleCompletionHa | |||||||||
let lastUsage | ||||||||||
|
||||||||||
for await (const chunk of completion) { | ||||||||||
const delta = chunk.choices[0]?.delta | ||||||||||
// Handle chunks that might not have choices array (e.g., usage-only chunks) | ||||||||||
const delta = chunk.choices?.[0]?.delta | ||||||||||
const usage = chunk.usage as LiteLLMUsage | ||||||||||
|
||||||||||
if (delta?.content) { | ||||||||||
yield { type: "text", text: delta.content } | ||||||||||
// Check for reasoning/thinking content in the delta | ||||||||||
// LiteLLM may pass through reasoning content from underlying models | ||||||||||
if (delta) { | ||||||||||
if ("reasoning" in delta && delta.reasoning && typeof delta.reasoning === "string") { | ||||||||||
yield { type: "reasoning", text: delta.reasoning } | ||||||||||
} | ||||||||||
|
||||||||||
// Also check for thinking content (alternative field name) | ||||||||||
if ("thinking" in delta && delta.thinking && typeof delta.thinking === "string") { | ||||||||||
yield { type: "reasoning", text: delta.thinking } | ||||||||||
} | ||||||||||
|
||||||||||
// Check for reasoning_content (another possible field name) | ||||||||||
if ( | ||||||||||
"reasoning_content" in delta && | ||||||||||
delta.reasoning_content && | ||||||||||
typeof delta.reasoning_content === "string" | ||||||||||
) { | ||||||||||
yield { type: "reasoning", text: delta.reasoning_content } | ||||||||||
} | ||||||||||
|
||||||||||
if (delta.content) { | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [P2] Add a type guard for delta.content to ensure only string fragments are emitted (prevents accidental non-string values from being yielded).
Suggested change
|
||||||||||
yield { type: "text", text: delta.content } | ||||||||||
} | ||||||||||
} | ||||||||||
|
||||||||||
if (usage) { | ||||||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] Emit at most one reasoning chunk per delta to avoid duplicated output when multiple alias fields are present in a single chunk.