fix(modes): custom modes under custom path not showing

[elianiva]

Related GitHub Issue

Closes: #8122

Roo Code Task Context (Optional)

Description

Upon setting custom storage path, custom modes didn't show up. This PR fixes it by replacing hardcoded global storage path to the one set by the user.

Test Procedure

1. Set custom global storage path
2. Create a new mode
3. Restart, it should still show the custom modes we've defined earlier in the custom directory.

Pre-Submission Checklist

• Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
• Scope: My changes are focused on the linked issue (one major feature/fix per PR).
• Self-Review: I have performed a thorough self-review of my code.
• Testing: New and/or updated tests have been added to cover my changes (if applicable).
• Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
• Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch

@elianiva

---

Important

Fixes issue with custom modes not showing by using user-defined storage path instead of hardcoded path.

• Behavior:
  • Replaces hardcoded global storage path with user-defined path in createModeInstructions() in create-mode.ts and getModesSection() in modes.ts.
  • Ensures settings directory is created using ensureSettingsDirectoryExists() in modes.ts.
• Utilities:
  • Updates ensureSettingsDirectoryExists() in globalContext.ts to use getSettingsDirectoryPath() for custom path handling.
  • Modifies migrateSettings() in migrateSettings.ts to use getSettingsDirectoryPath() for determining settings directory.

^{This description was created by for 9e93dd8. You can customize this summary. It will automatically update as commits are pushed.}

[roomote]

I found a couple of small follow-ups to improve correctness and maintainability.

[roomote]

[P2] Using getSettingsDirectoryPath() here will create the settings directory before the existence check below. That makes the early-return branch ("No settings directory found, no migrations necessary") unreachable. Consider removing the existence check/log or computing the path without side effects before checking, so logs reflect actual conditions.