fix: support line range regardless of max line read #8500
+84
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| ${isMultipleReadsEnabled ? `**IMPORTANT: You can read a maximum of ${maxConcurrentReads} files in a single request.** If you need to read more files, use multiple sequential read_file requests.` : "**IMPORTANT: Multiple file reads are currently disabled. You can only read one file at a time.**"} | ||
| ${args.partialReadsEnabled ? `By specifying line ranges, you can efficiently read specific portions of large files without loading the entire file into memory.` : ""} | ||
| ${args.partialReadsEnabled ? `**Line ranges bypass the "Always read entire file" setting** - when you specify explicit line ranges, you can read any lines from any file regardless of the maxReadFileLine configuration. This is useful for targeted work based on tool outputs that reference specific line numbers (e.g., linters, search results, diffs).` : ""} |
There was a problem hiding this comment.
[P3] Docs alignment: New line‑range behavior is clear. While touching this doc, consider updating the earlier supported-formats sentence to reflect current code — it still says "PDF and DOCX" only, but the code also supports IPYNB. For consistency with implementation, mention all three, e.g. "PDF, DOCX, and IPYNB". See src/integrations/misc/extract-text.ts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #8077
Roo Code Task Context (Optional)
Description
This PR tells the model to support line-range read even when max line read is enabled.
Test Procedure
Added 3 more test cases to cover other use cases in the test file.
Pre-Submission Checklist
Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
@elianiva
Important
Enhance
read_filetool to support line ranges regardless ofmaxReadFileLinesetting, with updated tests to verify behavior.read-file.ts: Line ranges now bypassmaxReadFileLinesetting, allowing specific line reads regardless of the limit.Task.ts: Always enable partial reads by settingpartialReadsEnabledtotrue.readFileTool.spec.ts: Add tests to verify line ranges bypassmaxReadFileLinein various scenarios, including when set to 0, -1, or a positive number.This description was created by
for 0b4df8e. You can customize this summary. It will automatically update as commits are pushed.