fix(ui5-datetime-picker): restore last valid value #12202
+37
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously our in
ui5-datetime-pickerwhen a user enters an invalid value (e.g., "invalid text") and then selects a new date from the calendar, the time portion was being reset to 12:00:00 AM instead of preserving the previously valid time.The reason behind that is that the component was not storing the last valid time value.
So, when a new date was selected, the component had no reference to the previously valid time, so it defaulted to midnight (12:00:00 AM).
We now store the valid value and fallback to it whenever needed. And if no value was provided, the default behaviour is preserved (auto selects the current time)
Fixes: #11376