fix(ui5-form-item): update host element display #12208
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isElementHidden
method called internally bygetFirstFocusableElement
returns true on Safari for the ui5-form-item, considering the element as hidden, skipping the traverse of its children. This happens, becauseel.offsetHight
andoffsetWidth
for the host custom element (ui5-form-item
custom element in the specific issue) are 0 on Safari.This probably happens for other components - Safari's layout engine doesn't always calculate dimensions correctly for the host element when content is in shadow DOM.
Solution - add display to the host element:
Fixes: #12201