DS-746 | @ericbakenhus | Additional copy changes #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericbakenhus
commented
May 30, 2024
| linkType="url" | ||
| link={{ | ||
| url: 'https://giving.stanford.edu/gift-policy', | ||
| <main id="main-content"> |
There was a problem hiding this comment.
Added main. Skip nav expects it to exist.
ericbakenhus
commented
May 30, 2024
| </CenteredContainer> | ||
| <div> | ||
| <iframe | ||
| title="Citizenship form for foreign source reporting" |
There was a problem hiding this comment.
Added title to iframe so we meet 4.1.2.
ericbakenhus
commented
May 30, 2024
| link={{ | ||
| url: 'https://giving.stanford.edu/gift-policy', | ||
| <main id="main-content"> | ||
| <CenteredContainer classes="su-max-w-800"> |
There was a problem hiding this comment.
I tossed a max width on the text to get closer to meeting 1.4.8. It's technically AAA, but it seemed like a good idea.
ericbakenhus
commented
May 30, 2024
Comment on lines
+38
to
+53
| <p> | ||
| The federal government requires institutions of higher education, | ||
| such as Stanford, to report gifts and other payments from a donor | ||
| who is not a U.S. citizen when that donor makes gifts and other | ||
| payments to Stanford with an aggregate value of $250,000 or more in | ||
| a calendar year. Stanford must also report gifts and other payments | ||
| received from a donor who is associated with one of certain specific | ||
| countries (the list, which may change over time, currently includes | ||
| China (while excluding Hong Kong), Russia, Iran, and North Korea), | ||
| when that donor makes gifts and other payments to Stanford having an | ||
| aggregate value of $50,000 or more during a reporting period that | ||
| runs from July 1 to June 30 of the following year. Because your | ||
| generous gift(s) meet one or both of these reporting thresholds, we | ||
| ask that you please provide the information requested below. Thank | ||
| you. | ||
| </p> |
ericbakenhus
commented
May 30, 2024
Comment on lines
+57
to
+64
| <SbLink | ||
| linkType="url" | ||
| link={{ | ||
| url: 'https://giving.stanford.edu/gift-policies/', | ||
| }} | ||
| > | ||
| Gift Policy website | ||
| </SbLink> |
There was a problem hiding this comment.
Fix link and make text descriptive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Review By (Date)
Criticality
Review Tasks
Setup tasks and/or behavior to test
Associated Issues and/or People