Skip to content

Release/v4.2.0 #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 24, 2024
Merged

Release/v4.2.0 #449

merged 3 commits into from
Oct 24, 2024

Conversation

sherakama
Copy link
Member

READY FOR REVIEW

Summary

  • Allow for multiple countdowns
  • Updated endowed positions list

Review By (Date)

  • End of the week

Criticality

  • Normal

su-sws-jira and others added 3 commits August 1, 2024 14:11
@su-sws-jira
Merge main into dev
905c660
@wmui51
Feat/allow multiple countdowns (#425)
6563920 
* allow multiple instances of the countdown clock
* set time via storyblok
* fix offset
* add isDST blok prop
@wmui51
update endowed positions dataset (#448)
7a8864c 
* update endowed positions dataset

* update entry
@sherakama sherakama added the minor minor label Oct 23, 2024
wmui51
wmui51 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@wmui51 wmui51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, looks like the countdown updates will go live, and that was working as expected when i tested, so should be good to go.

@sherakama
Copy link
Member Author

Thanks @wmui51

Any changes needed on the Storyblok side?

@wmui51
Copy link
Contributor

wmui51 commented Oct 24, 2024 •
edited
Loading

@sherakama yup, I will update the component options on the prod Storyblok build to match that of dev when this is released. Thanks for pointing that out.

yvonnetangsu
yvonnetangsu approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@yvonnetangsu yvonnetangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for confirming that the countdown is production ready too @wmui51! GTG @sherakama 🚀

@sherakama
Copy link
Member Author

Thanks @wmui51 and @yvonnetangsu

@sherakama sherakama merged commit 63c57f7 into main Oct 24, 2024
6 checks passed
@sherakama sherakama deleted the release/v4.1.17 branch October 24, 2024 17:22
@wmui51
Copy link
Contributor

wmui51 commented Oct 25, 2024

component in prod Storyblok is configured to match the fields that are on dev.

@sherakama
Copy link
Member Author

Thank you @wmui51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmui51 wmui51 wmui51 approved these changes

@yvonnetangsu yvonnetangsu yvonnetangsu approved these changes

@forrestglick forrestglick Awaiting requested review from forrestglick

Assignees
No one assigned
Labels
minor minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sherakama @wmui51 @yvonnetangsu @su-sws-jira