Skip to content

DS-1445 | CTA Group component #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Jun 16, 2025
Merged

DS-1445 | CTA Group component #501

merged 33 commits into from
Jun 16, 2025

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Jun 16, 2025

READY FOR REVIEW

Summary

  • Create CTA Group component
  • Add getNumsBlok utility

Review By (Date)

  • Retro

Criticality

  • 4

Review Tasks

Setup tasks and/or behavior to test

  1. Go to https://deploy-preview-501--adapt-giving.netlify.app/contact
  2. Check that the CTA group looks the same as the one on live https://giving.stanford.edu/contact/ (except for the width of the group - that's being controlled in the parent SbSection component which hasn't been worked on yet)
  3. Look at code

Associated Issues and/or People

yvonnetangsu and others added 30 commits June 11, 2025 16:54
* next:
  Update storyblok things and next (#495)

# Conflicts:
#	app/global-error.tsx
#	components/StoryblokProvider.tsx
#	package-lock.json
#	package.json
#	utilities/storyblok.tsx
Co-authored-by: Sherakama <sheamck@stanford.edu>
Co-authored-by: Sherakama <sheamck@stanford.edu>
Copy link

netlify bot commented Jun 16, 2025

Deploy Preview for adapt-giving ready!

Name Link
🔨 Latest commit b492e07
🔍 Latest deploy log https://app.netlify.com/projects/adapt-giving/deploys/685084eed82263000861e08b
😎 Deploy Preview https://deploy-preview-501--adapt-giving.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@yvonnetangsu yvonnetangsu changed the base branch from dev to next June 16, 2025 18:35
@yvonnetangsu yvonnetangsu requested a review from Copilot June 16, 2025 18:45
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the new CTA Group component along with several updates to Storyblok components and the CTA component suite. Key changes include:

  • Updating imports from '@storyblok/react' to '@storyblok/react/rsc' for multiple components.
  • Creating a new SbCtaGroup component that leverages the CTA Group and CreateBloks components.
  • Adding several new CTA components and updating related types and styles.

Reviewed Changes

Copilot reviewed 49 out of 49 changed files in this pull request and generated no comments.

Show a summary per file
File Description
components/Storyblok/SbLandingPage.tsx Updated Storyblok import to use @storyblok/react/rsc.
components/Storyblok/SbInteriorPage.tsx Updated Storyblok import to use @storyblok/react/rsc.
components/Storyblok/SbGlobalFooterPicker.tsx Updated Storyblok import to use @storyblok/react/rsc.
components/Storyblok/SbGlobalFooter.tsx Updated Storyblok import to use @storyblok/react/rsc.
components/Storyblok/SbCtaLink.tsx Refactored to leverage the new CTA components and updated CTA prop types.
components/Storyblok/SbCtaGroup.tsx Added new CTA Group component implementation.
components/Storyblok/SbCampaignPage.tsx Updated Storyblok import to use @storyblok/react/rsc.
components/Storyblok/SbBasicCard.tsx Added a basic card component as a placeholder.
components/RichText/RichText.tsx Cast inline link configuration to SbLinkType explicitly.
components/HeroIcon/HeroIcon.styles.tsx Updated icon mappings and spacing adjustments.
components/Cta/* Introduced new CTA components (CtaButton, CtaExternalLink, CtaNextLink, CtaLink, CtaGroup, CtaContent), along with updated types and styles.
components/CreateBloks.tsx Modified to optionally render list items when isListItems is true.
Comments suppressed due to low confidence (1)

components/Storyblok/SbCtaLink.tsx:42

  • [nitpick] Consider using the destructured variable 'linkText' instead of accessing 'props.blok.linkText' directly for consistency and improved readability.
if (!props.blok.linkText) {

* next:
  DS-1499 | CTA Link and Buttons (#494)

# Conflicts:
#	components/Cta/Cta.styles.ts
#	components/Cta/Cta.types.ts
#	components/Cta/index.ts
#	utilities/storyblok.tsx
@yvonnetangsu yvonnetangsu requested a review from sherakama June 16, 2025 19:30
Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@sherakama
Copy link
Member

The CTA's have slightly more padding/height to them in the new one but I like it so green lights.
Screenshot 2025-06-16 at 13 49 36

@yvonnetangsu
Copy link
Member Author

yvonnetangsu commented Jun 16, 2025

The CTA's have slightly more padding/height to them in the new one but I like it so green lights.

Good eye @sherakama! I pushed up a reduction in the leading of the CTA text which would make the button shorter like on live 😄

I like the slightly bigger buttons myself but not sure if that'll cause any unintended consequences so having it match the live site more closely for now.

@yvonnetangsu yvonnetangsu merged commit 5503b7e into next Jun 16, 2025
5 checks passed
@yvonnetangsu yvonnetangsu deleted the DS-1445_cta-group branch June 16, 2025 20:59
yvonnetangsu added a commit that referenced this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants