-
Notifications
You must be signed in to change notification settings - Fork 1
DS-1445 | CTA Group component #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* next: Update storyblok things and next (#495) # Conflicts: # app/global-error.tsx # components/StoryblokProvider.tsx # package-lock.json # package.json # utilities/storyblok.tsx
Co-authored-by: Sherakama <sheamck@stanford.edu>
Co-authored-by: Sherakama <sheamck@stanford.edu>
✅ Deploy Preview for adapt-giving ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces the new CTA Group component along with several updates to Storyblok components and the CTA component suite. Key changes include:
- Updating imports from '@storyblok/react' to '@storyblok/react/rsc' for multiple components.
- Creating a new SbCtaGroup component that leverages the CTA Group and CreateBloks components.
- Adding several new CTA components and updating related types and styles.
Reviewed Changes
Copilot reviewed 49 out of 49 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
components/Storyblok/SbLandingPage.tsx | Updated Storyblok import to use @storyblok/react/rsc. |
components/Storyblok/SbInteriorPage.tsx | Updated Storyblok import to use @storyblok/react/rsc. |
components/Storyblok/SbGlobalFooterPicker.tsx | Updated Storyblok import to use @storyblok/react/rsc. |
components/Storyblok/SbGlobalFooter.tsx | Updated Storyblok import to use @storyblok/react/rsc. |
components/Storyblok/SbCtaLink.tsx | Refactored to leverage the new CTA components and updated CTA prop types. |
components/Storyblok/SbCtaGroup.tsx | Added new CTA Group component implementation. |
components/Storyblok/SbCampaignPage.tsx | Updated Storyblok import to use @storyblok/react/rsc. |
components/Storyblok/SbBasicCard.tsx | Added a basic card component as a placeholder. |
components/RichText/RichText.tsx | Cast inline link configuration to SbLinkType explicitly. |
components/HeroIcon/HeroIcon.styles.tsx | Updated icon mappings and spacing adjustments. |
components/Cta/* | Introduced new CTA components (CtaButton, CtaExternalLink, CtaNextLink, CtaLink, CtaGroup, CtaContent), along with updated types and styles. |
components/CreateBloks.tsx | Modified to optionally render list items when isListItems is true. |
Comments suppressed due to low confidence (1)
components/Storyblok/SbCtaLink.tsx:42
- [nitpick] Consider using the destructured variable 'linkText' instead of accessing 'props.blok.linkText' directly for consistency and improved readability.
if (!props.blok.linkText) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GTG
Good eye @sherakama! I pushed up a reduction in the leading of the CTA text which would make the button shorter like on live 😄 I like the slightly bigger buttons myself but not sure if that'll cause any unintended consequences so having it match the live site more closely for now. |
READY FOR REVIEW
Summary
Review By (Date)
Criticality
Review Tasks
Setup tasks and/or behavior to test
Associated Issues and/or People