-
Notifications
You must be signed in to change notification settings - Fork 2
added running-on-windows.md #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
client/running-on-windows.md
Outdated
## MyAcademicID registration | ||
You will need to perform a MyAcademicID registration on https://tech-docs.eduxchange.eu/registration.html . | ||
During registration set your "Redirect URLs" to where you expect your copy of student-mobility-inteken-ontvanger-generiek | ||
to run for external tests (f.eks. https://AIT-DWEBEUT01.win.dtu.dk/redirect_uri/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this point to an example domain, instead of your own domain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point of using AIT-DWEBEUT01.win.dtu.dk was to emphasize not to use example.com for those who have not read the full java code yet :).
but I can see your point that we should not have an institute-specific URL in the text. I will remove the dtu.dk URL, but leave the reminder to not use example.com.
client/running-on-windows.md
Outdated
(this will not show up in the address bar) - this pageload will eventually time out because no service is running at | ||
\<Redirect URL\>, this is fine. | ||
|
||
If you registered ``https://ait-dwebeut01.win.dtu.dk/redirect_uri/`` as your redirect, the url you copy will look like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to an example url
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change it to "".
As with my comment above, I don't want to put "example.com" in case someone is just copy-pasting with out reading the code :).
|
||
Start as a normal Java application. | ||
|
||
You may need to make the following edits to application.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should point to the tech-docs website, this is euroteq specific
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I was writing this document as a euroteq specific guide. I had not considered that non-euroteq groups would be using this repo.
Maybe this document should be on the tech-docs website and not in the code base. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
[change]: removed references to dtu.dk on the doc
I will send a new PR with updates |
noted on how to run an enrolment test locally from a windows machine