Longitudinal #107
Draft
Longitudinal #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e measurement files and reads the noise tif file to the workspace. Currently also prints the noise data in command window
…into function. Added for loop to separate and track individual PMTs, not yet working
…generic_generator_template function to outside of long_elec func, added debug plots so can change to false if we don't want all the electrical noise histograms, reordered main for loop so data analysis done before plotting
… name rather than the full directory, but not sure necessary
Fixed lens_paper function name typo and added electrical_noise main function
…ation date, bug fix for if data has been moved around and original date lost
… must be month-year, does not work with just year
…T noise plots get replaced by FWHM and noise plots, in other datasets this does notr happen
…g_electrical_noise.
…th to plotting_template
…ed parseInputVariable function to be moved location.
…but not fully functional as yet
Collaborator
|
I'll just read through the code in the commits for now. Before I merge can you:
Probably just do those things for now and then I'll merge and test. If you commit those changes to your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new +longitudinal folder for analysis over time. First function- electrical noise, compares the FWHM of noise plots for each PMT over time.
Minor bug present in debug plots for some datasets