Skip to content

Monorepo diff fix #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Monorepo diff fix #24

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
158fe79
test
marinakalyuzhnaya Dec 10, 2021
5d8fcc7
test
marinakalyuzhnaya Dec 10, 2021
6c5f69d
test
marinakalyuzhnaya Dec 10, 2021
8e55fd5
test
marinakalyuzhnaya Dec 10, 2021
8281203
clean-up
marinakalyuzhnaya Dec 10, 2021
5b6feda
clean-up
marinakalyuzhnaya Dec 10, 2021
11099f0
clean-up
marinakalyuzhnaya Dec 10, 2021
6d8f686
clean-up
marinakalyuzhnaya Dec 10, 2021
cd9cbf0
Merge branch 'master' into monorepo_diff_fix
eeshdarthvader Apr 21, 2022
d3bee1f
latest master
Jan 18, 2023
32c421e
node 18
Jan 18, 2023
25ec516
diff check
Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dist/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6086,8 +6086,8 @@ const commentForMonorepo = (
let report = lcovObj.lcov;

if (baseLcov) {
const onlyInLcov = lcovObj.lcov.filter(comparer(baseLcov));
const onlyInBefore = baseLcov.filter(comparer(lcovObj.lcov));
const onlyInLcov = lcovObj.lcov.filter(comparer(baseLcov.lcov));
const onlyInBefore = baseLcov.lcov.filter(comparer(lcovObj.lcov));
report = onlyInBefore.concat(onlyInLcov);
}

Expand Down Expand Up @@ -6302,7 +6302,7 @@ const getLcovBaseFiles = (dir, filelist) => {
fileArray = fs__default.statSync(path.join(dir, file)).isDirectory()
? getLcovBaseFiles(path.join(dir, file), fileArray)
: fileArray
.filter(f => f.path.includes("lcov-base.info"))
.filter(f => f.path.includes("lcov-base"))
.concat({
name: dir.split("/")[1],
path: path.join(dir, file),
Expand Down
4 changes: 2 additions & 2 deletions src/comment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ const commentForMonorepo = (
let report = lcovObj.lcov;

if (baseLcov) {
const onlyInLcov = lcovObj.lcov.filter(comparer(baseLcov));
const onlyInBefore = baseLcov.filter(comparer(lcovObj.lcov));
const onlyInLcov = lcovObj.lcov.filter(comparer(baseLcov.lcov));
const onlyInBefore = baseLcov.lcov.filter(comparer(lcovObj.lcov));
report = onlyInBefore.concat(onlyInLcov);
}

Expand Down
2 changes: 1 addition & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const getLcovBaseFiles = (dir, filelist) => {
fileArray = fs.statSync(path.join(dir, file)).isDirectory()
? getLcovBaseFiles(path.join(dir, file), fileArray)
: fileArray
.filter(f => f.path.includes("lcov-base.info"))
.filter(f => f.path.includes("lcov-base"))
.concat({
name: dir.split("/")[1],
path: path.join(dir, file),
Expand Down