Fix handling for default algorithms for DualLinearProblems #775
+37
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+132
to
+137
| function SciMLBase.init(prob::DualAbstractLinearProblem, alg::DefaultLinearSolver, args...; kwargs...) | ||
| if alg.alg === DefaultAlgorithmChoice.GenericLUFactorization | ||
| return __init(prob, alg, args...; kwargs...) | ||
| else | ||
| return __dual_init(prob, alg, args...; kwargs...) | ||
| end |
There was a problem hiding this comment.
Tests added. Looks good on 1.11 but fails on LTS
|
tests fail |
|
CI is having some issues here, some are complaining about Pkg not being available, and one says that Julia isn't a recognized executable. |
|
NoPre is a real failure |
|
So the normal default algorithm But the default algorithm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
This makes it so that the default alg is chosen based on the primal A and b before going to make the Dual cache. This also means that for small problems GenericLU will be used, and the cache will be a normal LinearCache.