temurin-25: Make sure the manifests match those of previous LTS versions #564

f-cramer · 2025-09-25T13:15:10Z

The ".LTS" version suffix is removed for the other LTS manifests, so it should be removed for version 25 as well

Relates to #560

I have read the Contributing Guide.

Summary by CodeRabbit

Bug Fixes
- Corrected version display for Temurin 25 JDK/JRE by removing the “.LTS” suffix.
Chores
- Standardized version formatting for Temurin 25 JDK/JRE packages (e.g., 25.0.0-36.0).
- Adjusted update checks and hash retrieval to align with the new version format.

coderabbitai · 2025-09-25T13:15:18Z

Walkthrough

Removes the ".LTS" suffix from Temurin 25 JDK/JRE manifest versions, updates the checkver script to strip ".LTS" in addition to replacing "+" with "-", and switches autoupdate hash extraction from "regex" to "find" in both manifests.

Changes

Cohort / File(s)	Summary
Temurin 25 manifests `bucket/temurin25-jdk.json`, `bucket/temurin25-jre.json`	Version updated from 25.0.0-36.0.LTS to 25.0.0-36.0; checkver script now also removes ".LTS" after replacing '+' with '-'; autoupdate hash key renamed from "regex" to "find".

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Dev as Dev/CI
  participant Scoop as Scoop Manifest
  participant API as Upstream API
  participant Auto as Autoupdate

  Dev->>Scoop: run checkver
  Scoop->>API: fetch latest release
  API-->>Scoop: tag with possible "+" and ".LTS"
  Note over Scoop: Normalize: replace "+"→"-", remove ".LTS"
  Scoop-->>Dev: computed version (e.g., 25.0.0-36.0)

  Dev->>Auto: autoupdate manifest
  Auto->>API: fetch assets/notes
  Note over Auto: Extract hash via "find" (not "regex")
  Auto-->>Dev: updated hash field

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Add Temurin JDK25 and JRE25 version 25.0.0-36 to scoop #560: Adjusts Temurin 25 JDK/JRE manifests with similar version normalization and autoupdate hash extraction changes.

Suggested labels

review-needed

Suggested reviewers

se35710

Poem

Thump-thump, my paws approve this tweak—
Plus to dash, no LTS to seek.
Hashes found with sharper mind,
Not with regex—now we find.
JDK, JRE hop in line—
Temurin 25, polished fine. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title clearly specifies that the change concerns the Temurin 25 manifests and indicates the intent to align them with previous LTS versions, which matches the primary modification of removing the “.LTS” suffix to maintain consistency.
Description Check	✅ Passed	The description provides a concise summary of the change, includes the relevant issue reference with “Relates to #560,” and confirms the contributor has read the contributing guide, fulfilling all required sections of the repository’s description template.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5f50499 and 898b4d0.

📒 Files selected for processing (2)

bucket/temurin25-jdk.json (3 hunks)
bucket/temurin25-jre.json (3 hunks)

🔇 Additional comments (4)

bucket/temurin25-jre.json (2)

20-20: Version normalization matches prior LTS manifests

Thanks for aligning the semver normalization with the other Temurin LTS manifests; this keeps checkver output stable across the family. ✅

35-37: Hash scraping tweak LGTM

Switching to find against the SHA256 sidecar works with Adoptium’s file format and simplifies the autoupdate stanza. Nicely done.

bucket/temurin25-jdk.json (2)

20-20: Consistent version cleanup

Removing the .LTS suffix in checkver keeps the reported version consistent with the updated manifest. Looks good.

35-37: Autoupdate hash extraction confirmed

The new find regex correctly picks up the SHA256 from the sidecar file, mirroring the JRE manifest. 👍

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

f-cramer · 2025-09-25T13:15:20Z

/verify

github-actions · 2025-09-25T13:15:54Z

github-actions · 2025-09-25T13:16:19Z

f-cramer · 2025-09-30T15:17:28Z

Anything more I can do to get this merged?

temurin-25: Make sure the manifests match those of previous LTS versions

898b4d0

github-actions bot added the review-needed label Sep 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

temurin-25: Make sure the manifests match those of previous LTS versions #564

temurin-25: Make sure the manifests match those of previous LTS versions #564

Uh oh!

f-cramer commented Sep 25, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Sep 25, 2025 •

edited

Loading

Uh oh!

f-cramer commented Sep 25, 2025

Uh oh!

github-actions bot commented Sep 25, 2025

Uh oh!

github-actions bot commented Sep 25, 2025

Uh oh!

f-cramer commented Sep 30, 2025

Uh oh!

Uh oh!

temurin-25: Make sure the manifests match those of previous LTS versions #564

Are you sure you want to change the base?

temurin-25: Make sure the manifests match those of previous LTS versions #564

Uh oh!

Conversation

f-cramer commented Sep 25, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

f-cramer commented Sep 25, 2025

Uh oh!

github-actions bot commented Sep 25, 2025

temurin25-jdk

temurin25-jre

Uh oh!

github-actions bot commented Sep 25, 2025

temurin25-jdk

temurin25-jre

Uh oh!

f-cramer commented Sep 30, 2025

Uh oh!

Uh oh!

f-cramer commented Sep 25, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 25, 2025 •

edited

Loading