Skip to content

Conversation

Scarange
Copy link

@Scarange Scarange commented Sep 27, 2025

close #568

This PR adds support for installing and updating Amazon Corretto 25.

The install and update script is based on the Corretto 23 script.

Summary by CodeRabbit

  • New Features
    • Added Amazon Corretto 25 JDK (Windows x64) package to the catalog.
    • Installs the JDK, adds its bin directory to PATH, and sets JAVA_HOME automatically.
    • Supports automatic version detection and templated updates to keep installs current.
    • Verifies downloads with SHA-256 checksums to ensure integrity.

Copy link

coderabbitai bot commented Sep 27, 2025

Walkthrough

Adds a new Scoop manifest for Amazon Corretto 25 JDK (Windows x64) that specifies metadata, 64‑bit download URL and SHA‑256, extract directory, PATH and JAVA_HOME env settings, a remote JSON checkver, and autoupdate rules that fetch versioned URL and checksum.

Changes

Cohort / File(s) Summary of Changes
New Scoop manifest: Corretto 25 JDK
bucket/corretto25-jdk.json
New JSON manifest added. Contains metadata (description, homepage, license, version), architecture.64bit download URL and SHA‑256, extract_dir, env entries (PATH, JAVA_HOME), checkver using a remote index JSON with JSONPath+regex, and autoupdate rules including templated download URL and dynamic checksum retrieval.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant User
  participant Scoop
  participant Manifest as Corretto25 Manifest
  participant CDN as Corretto CDN
  participant Checksums as Checksums JSON

  rect rgb(240,245,255)
    note over User,Scoop: Install flow
    User->>Scoop: scoop install corretto25-jdk
    Scoop->>Manifest: read URL, extract_dir, env
    Scoop->>CDN: download archive (versioned URL)
    Scoop->>Checksums: fetch/verify SHA‑256
    Scoop->>Scoop: extract to extract_dir
    Scoop->>User: update PATH, set JAVA_HOME
  end

  rect rgb(245,255,245)
    note over Scoop,Manifest: Update check
    Scoop->>Manifest: checkver (index JSON + JSONPath/regex)
    Manifest-->>Scoop: latest version
    alt new version available
      Scoop->>Manifest: apply autoupdate templates (URL, extract_dir)
      Scoop->>Checksums: fetch checksum via JSONPath
      Scoop-->>User: ready to update
    else up-to-date
      Scoop-->>User: no update
    end
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • se35710

Poem

Hop hop hooray, a JDK today!
Corretto lands, all set to play.
Paths aligned and hashes true,
Updates probe the JSON view.
(\_/) ☕ JAVA_HOME—ready, too!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description does not follow the repository’s required template: it uses “close [#568]” instead of the mandated “Closes #568” syntax, omits the checklist confirming the contributor has read the Contributing Guide, and lacks the template’s structured sections for issue linkage and contribution confirmation. Please revise the PR description to use the exact template: include a “Closes #568” line (or “Relates to #568”), add the checklist item “- [ ] I have read the Contributing Guide,” and ensure all required template headings and confirmations are present.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly and accurately describes the primary change of adding support for Corretto 25, which aligns with the files and manifest updates in this changeset. It is specific and clear, allowing a teammate to understand the main purpose at a glance.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

  • Public repositories are always opted into early access features.
  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

corretto25-jdk

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c9301e8 and 3bd45fd.

📒 Files selected for processing (1)
  • bucket/corretto25-jdk.json (1 hunks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Adding Corretto 25
1 participant