-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[rb] Relax json dependency restriction in Ruby gemspec #16387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
PR Code Suggestions ✨Explore these optional code suggestions:
|
Its A minor issue that is Having a 2 way deadlock. That is interfering with the json build version. So i kindly request the Mediators to take necessary action |
I don't know if this resolves the dependency issue, but there are problems with this PR:
|
Thanks for the review, @cgoldberg 🙏 Removed the copied LICENSE and NOTICE files from rb/ Added symbolic links pointing to the root-level files instead Removed the committed binary .gem file Added *.gem to .gitignore to prevent future commits of built gems The PR now only includes the intended change to relax the json dependency in the gemspec. |
NOTICE wasn't removed.
no you didn't, but I don't think we need them anyway
no you didn't. Also, I don't think we want to change the dependency specifier in the way you have done it. There's really nothing in this PR worth merging. We will take care of this before the 4.36 release. |
User description
##16385 Related Issues
What does this PR do?
Relaxes the
json
dependency restriction in the Ruby gemspec.Previously, the dependency was locked to
<= 2.13.2
, which caused unnecessary downgrades of thejson
gem in production environments.This PR updates it to allow
>= 2.13.0
.Changed this line in
rb/selenium-webdriver.gemspec
:PR Type
Enhancement
Description
Relaxed
json
dependency from<= 2.13.2
to>= 2.13.0
Added Apache License 2.0 file to Ruby binding
Added NOTICE file with copyright information
Diagram Walkthrough
File Walkthrough
selenium-webdriver.gemspec
Relaxed json dependency version constraint
rb/selenium-webdriver.gemspec
json
dependency from<= 2.13.2
to>= 2.13.0
LICENSE
Added Apache License 2.0 file
rb/LICENSE
NOTICE
Added copyright notice file
rb/NOTICE