Skip to content

Fixed issues with some specific characters inside the Url. Custom scripts will need to update the previous xurl_ logic. #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

Fixed issues with some specific characters inside the Url. Custom scripts will need to update the previous xurl_ logic. #859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 12 additions & 43 deletions src/Sidekick.Common/Extensions/StringExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,32 +34,6 @@ public static string DecodeBase64(this string input)
return Encoding.UTF8.GetString(Convert.FromBase64String(input));
}

/// <summary>
/// Encode a string for URL transfer
/// </summary>
public static string EncodeUrl(this string input)
{
if (string.IsNullOrEmpty(input))
{
return input;
}

return HttpUtility.UrlEncode(input);
}

/// <summary>
/// Decodes a Url Encodeded String
/// </summary>
public static string DecodeUrl(this string input)
{
if (string.IsNullOrEmpty(input))
{
return input;
}

return HttpUtility.UrlDecode(input);
}

/// <summary>
/// Encode a string in Base64 for URL transfer
/// </summary>
Expand All @@ -70,12 +44,11 @@ public static string DecodeUrl(this string input)
return null;
}

if (input.HasInvalidUrlCharacters())
{
return $"xurl_{input.EncodeBase64().EncodeUrl()}";
}

return input;
var url = input.EncodeBase64();
url = url.Replace('+', '-')
.Replace('/', '_')
.Replace('=', '.');
return $"base64_{url}";
}

/// <summary>
Expand All @@ -88,21 +61,17 @@ public static string DecodeUrl(this string input)
return null;
}

if (!input.StartsWith("xurl_"))
if (!input.StartsWith("base64_"))
{
return input;
}

var substr = input.Substring(5);
return DecodeUrl(substr).DecodeBase64();
}

/// <summary>
/// Indicates if the string has invalid characters
/// </summary>
public static bool HasInvalidUrlCharacters(this string input)
{
return input.EncodeUrl() != input;
var url = input.Substring(7)
.Replace('-', '+')
.Replace('_', '/')
.Replace('.', '=');
url = url.DecodeBase64();
return url;
}

public static int GetDeterministicHashCode(this string str)
Expand Down
Loading