Skip to content

Conversation

Rajan-p-simform
Copy link

This pull request introduces significant updates to the Android project, including upgrading dependencies, enhancing compatibility with newer Android SDKs, and implementing modern features like view binding and media picker APIs. The most important changes are grouped into dependency updates, SDK compatibility enhancements, and feature additions.

Dependency Updates:

  • Updated dependencies in SSffmpegVideoOperation/build.gradle and app/build.gradle to newer versions, including androidx.core:core-ktx (1.9.0), androidx.appcompat:appcompat (1.7.1), and com.google.android.material:material (1.12.0). [1] [2]

Feature Additions:

  • Introduced media picker APIs (ActivityResultContracts.PickVisualMedia and ActivityResultContracts.PickMultipleVisualMedia) in BaseActivity.kt for modern file selection workflows. [1] [2]
  • Added new utility methods in Common.kt for handling file paths, saving temporary files, and retrieving media duration. [1] [2] [[3]]

@Rajan-p-simform Rajan-p-simform requested a review from Copilot July 7, 2025 05:54
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades Android SDK and Gradle tooling, replaces Kotlin synthetic views with view binding, and implements modern media picker APIs alongside utility methods for file handling.

  • Bumped Gradle, compile/target SDK versions, dependencies, enabled viewBinding
  • Replaced kotlinx.android.synthetic usages with generated Binding classes
  • Added ActivityResultContracts file pickers and Common helpers for URI-to-path conversion

Reviewed Changes

Copilot reviewed 40 out of 41 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
gradle/wrapper/gradle-wrapper.properties Updated Gradle distribution to 8.5
app/build.gradle Migrated to viewBinding, bumped compileSdk/targetSdk to 35
app/src/main/java/com/simform/videoimageeditor/BaseActivity.kt Registered PickVisualMedia contracts for single/multiple picks
SSffmpegVideoOperation/src/main/java/com/simform/videooperations/Common.kt Added saveFileToTempAndGetPath, getDurationFromFile, updated file path logic
app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/CombineVideosActivity.kt Updated picker logic for multiple media and binding refs
app/src/main/res/values/strings.xml Added time picker strings
app/src/main/AndroidManifest.xml Adjusted external storage permissions
Comments suppressed due to low confidence (1)

app/src/main/res/values/strings.xml:114

  • XML resource files do not support //–style comments; this line will break the XML parser. Wrap comments in instead.
    // Time Picker

@Rajan-p-simform Rajan-p-simform changed the title Feature/implement photo picker Implement photo picker Jul 7, 2025
@Rajan-p-simform Rajan-p-simform force-pushed the feature/implement-photo-picker branch from 0e2605d to 27ad481 Compare July 7, 2025 10:05
@Rajan-p-simform Rajan-p-simform force-pushed the feature/implement-photo-picker branch from 27ad481 to 857bda5 Compare July 9, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant