Skip to content

Conversation

Rajan-p-simform
Copy link

Support edge to edge for latest android devices

@Rajan-p-simform Rajan-p-simform requested a review from Copilot July 7, 2025 06:30
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds edge-to-edge support across the app by migrating to view binding, introducing a reusable toolbar component, and updating themes and layouts to remove the action bar and position views under the toolbar. It also upgrades build settings (JDK, Gradle) and adds time-picker resources.

  • Upgrade JDK to openjdk8 and Gradle wrapper to 8.5; suppress unsupported compileSdk warning
  • Change MaterialComponents theme parent to NoActionBar and add a ToolbarTitleTextAppearance style
  • Introduce enableEdgeToEdge extension, migrate activities to view binding, and include a toolbar_app in all layouts

Reviewed Changes

Copilot reviewed 77 out of 79 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
jitpack.yml Added openjdk8 to JDK matrix
gradle/wrapper/gradle-wrapper.properties Updated Gradle distribution to 8.5-bin.zip
app/src/main/res/values/themes.xml Switched base theme to NoActionBar
app/src/main/java/com/simform/videoimageeditor/utils/ExtensionsUtils.kt Added enableEdgeToEdge extension method
app/src/main/res/layout/toolbar_app.xml New reusable AppBarLayout/MaterialToolbar layout
app/src/main/res/values/strings.xml Added strings for time picker
app/src/main/java/com/simform/videoimageeditor/middlewareActivity/VideoProcessActivity.kt Migrated to view binding and edge-to-edge
Comments suppressed due to low confidence (4)

app/src/main/res/values/strings.xml:119

  • [nitpick] The string resource ID title is very generic and may collide with other resources or Android attributes. Consider renaming it to a more specific key, e.g. toolbar_title.
    <string name="title">title</string>

app/src/main/res/values/strings.xml:114

  • XML resource files don’t support // comments. Replace this with a proper XML comment (<!-- Time Picker -->) or remove the line.
    // Time Picker

app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/CutVideoUsingTimeActivity.kt:9

  • There is no enableEdgeToEdge in androidx.activity. Remove this import and keep only the utility import from com.simform.videoimageeditor.utils.
import androidx.activity.enableEdgeToEdge

app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/CompressVideoActivity.kt:8

  • Incorrect import of enableEdgeToEdge; remove this and use the extension from com.simform.videoimageeditor.utils.
import androidx.activity.enableEdgeToEdge

@Rajan-p-simform Rajan-p-simform force-pushed the feature/support-edge-to-edge branch from 616bfc2 to 32b4203 Compare July 7, 2025 13:36
@Rajan-p-simform Rajan-p-simform force-pushed the feature/support-edge-to-edge branch 2 times, most recently from 6807460 to 966ee7e Compare July 14, 2025 12:19
@Rajan-p-simform Rajan-p-simform force-pushed the feature/support-edge-to-edge branch from 966ee7e to c8fefeb Compare July 14, 2025 12:51
@Rajan-p-simform Rajan-p-simform force-pushed the feature/support-edge-to-edge branch from c8fefeb to 3490a0b Compare July 15, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant