Skip to content

Conversation

Rajan-p-simform
Copy link

  • Update query to limit the frame dublication

@Rajan-p-simform Rajan-p-simform requested a review from Copilot July 7, 2025 14:25
@Rajan-p-simform Rajan-p-simform changed the title Bugfix/more than 1000 frames dublicated Combine image and video leads to more than 1000 frame duplication. Jul 7, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates project configuration, migrates activities and layouts to use ViewBinding with an edge-to-edge helper, and adds a custom time picker widget with associated resources.

  • Upgrade build environment and Android settings (JDK versions, Gradle wrapper, compile SDK suppression)
  • Migrate all Activities to ViewBinding and apply edge-to-edge Insets via enableEdgeToEdge
  • Introduce a reusable toolbar, string entries for time picker, and a custom TimePicker widget/dialog

Reviewed Changes

Copilot reviewed 79 out of 81 changed files in this pull request and generated no comments.

Show a summary per file
File Description
jitpack.yml Add OpenJDK 8 to supported JDKs
gradle/wrapper/gradle-wrapper.properties Bump Gradle distribution to 8.5
gradle.properties Suppress unsupported compile SDK warning
app/src/main/res/values/strings.xml Add time-picker strings and toolbar title
app/src/main/res/layout/toolbar_app.xml New shared toolbar layout
app/src/main/res/layout/time_picker_*.xml Add TimePicker widget and dialog layouts
app/src/main/java/.../utils/ExtensionsUtils.kt Edge-to-edge insets extension
app/src/main/java/.../middlewareActivity/*Activity.kt Migrate to ViewBinding & edge-to-edge
app/src/main/java/.../videoProcessActivity/*Activity.kt Migrate to ViewBinding, add Android 14 media pickers
Comments suppressed due to low confidence (3)

app/src/main/res/values/strings.xml:114

  • XML does not support '//' comments—this will break resource parsing. Wrap that note in instead.
    // Time Picker

app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/CutVideoUsingTimeActivity.kt:9

  • This import is incorrect and will not resolve. You should import the enableEdgeToEdge extension from com.simform.videoimageeditor.utils.
import androidx.activity.enableEdgeToEdge

app/src/main/java/com/simform/videoimageeditor/middlewareActivity/OtherFFMPEGProcessActivity.kt:4

  • Duplicate/wrong extension import—remove this androidx.activity.enableEdgeToEdge import and rely on com.simform.videoimageeditor.utils.enableEdgeToEdge only.
import androidx.activity.enableEdgeToEdge

@Rajan-p-simform Rajan-p-simform force-pushed the bugfix/more-than-1000-frames-dublicated branch from 0760507 to 13b93f5 Compare July 15, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant