Skip to content

Conversation

Rajan-p-simform
Copy link

Optimise video compress query

  • Reduce size and provide better quality output video

@Rajan-p-simform Rajan-p-simform requested a review from Copilot July 8, 2025 05:17
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the build configuration, refactors UI layouts with a common toolbar, and migrates activities to view binding and modern media pickers.

  • Upgrade JDK/Gradle versions in CI and wrapper
  • Add a reusable toolbar layout and adjust themes
  • Migrate activities from synthetic imports to ViewBinding, ActivityResultContracts, and edge-to-edge support

Reviewed Changes

Copilot reviewed 79 out of 81 changed files in this pull request and generated 1 comment.

Show a summary per file
File(s) Description
jitpack.yml Added OpenJDK 8 alongside OpenJDK 11 for build compatibility
gradle/wrapper/gradle-wrapper.properties Upgraded Gradle distribution to version 8.5
app/src/main/res/values/themes.xml Switched to NoActionBar theme and added ToolbarTitleTextAppearance
app/src/main/res/values/strings.xml Added strings for time picker (note: invalid comment syntax)
app/src/main/res/layout/toolbar_app.xml & other layouts Introduced a shared toolbar include and updated Constraint layouts
app/src/main/java/**Activity.kt (all Activity classes) Migrated to ViewBinding, ActivityResultContracts, and edge-to-edge
Comments suppressed due to low confidence (5)

app/src/main/res/values/strings.xml:114

  • XML resource files do not support // comments. Replace this with a proper XML comment, e.g. <!-- Time Picker -->.
    // Time Picker

app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/CutVideoUsingTimeActivity.kt:9

  • This import is invalid. You should import your extension from com.simform.videoimageeditor.utils.enableEdgeToEdge instead of androidx.activity.enableEdgeToEdge.
import androidx.activity.enableEdgeToEdge

app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/CompressVideoActivity.kt:8

  • Replace this with import com.simform.videoimageeditor.utils.enableEdgeToEdge to pull in the correct extension function.
import androidx.activity.enableEdgeToEdge

app/src/main/java/com/simform/videoimageeditor/MainActivity.kt:4

  • Import the enableEdgeToEdge extension from your utils package: com.simform.videoimageeditor.utils.enableEdgeToEdge.
import androidx.activity.enableEdgeToEdge

app/src/main/java/com/simform/videoimageeditor/middlewareActivity/OtherFFMPEGProcessActivity.kt:4

  • This import points to a nonexistent symbol. Use com.simform.videoimageeditor.utils.enableEdgeToEdge instead.
import androidx.activity.enableEdgeToEdge

@Rajan-p-simform Rajan-p-simform force-pushed the feature/optimise-video-compress-query branch 2 times, most recently from 0e8d55e to 740f76e Compare July 8, 2025 05:25
@Rajan-p-simform Rajan-p-simform force-pushed the feature/optimise-video-compress-query branch from 740f76e to dda80c3 Compare July 15, 2025 11:46
@Rajan-p-simform Rajan-p-simform force-pushed the feature/optimise-video-compress-query branch from dda80c3 to f5f5024 Compare July 15, 2025 14:47
- Reduce size and provide better quality output video
@Rajan-p-simform Rajan-p-simform force-pushed the feature/optimise-video-compress-query branch from f5f5024 to 28d62e2 Compare July 15, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant