Skip to content

Conversation

Rajan-p-simform
Copy link

Developers can now choose the preferred performance mode for video operations, balancing between speed and output quality.
We offer three modes:

  • FASTEST – Optimized for speed; operations complete quickly but may result in lower output quality.

  • BALANCED – Offers a middle ground between processing time and quality.

  • HIGHEST – Prioritizes output quality; operations may take longer to complete.

This flexibility allows developers to adjust performance based on their specific use case.

@Rajan-p-simform Rajan-p-simform requested a review from Copilot July 8, 2025 05:34
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an encoding quality parameter to all video/audio processing calls (defaulting to FASTEST), migrates activities to ViewBinding with edge-to-edge support, and updates UI layouts (including a reusable toolbar and a watermark-position spinner).

  • Introduce EncodingQuality argument in FFmpeg queries, defaulting to FASTEST
  • Replace Kotlin synthetics with ViewBinding and apply enableEdgeToEdge
  • Add a generic toolbar layout and a position spinner in the watermark activity

Reviewed Changes

Copilot reviewed 80 out of 82 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
jitpack.yml Adds support for OpenJDK 8
gradle/wrapper/gradle-wrapper.properties Upgrades Gradle distribution to 8.5
app/src/main/res/values/strings.xml Adds time-picker strings (invalid XML comment present)
app/src/main/res/layout/toolbar_app.xml New reusable toolbar layout
app/src/main/java/.../VideoToGifActivity.kt Migrates to ViewBinding and adds EncodingQuality param
Comments suppressed due to low confidence (4)

app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/VideoToGifActivity.kt:61

  • New encodingQuality behavior is introduced here; consider adding unit or integration tests to verify that FASTEST, BALANCED, and HIGHEST modes produce expected outputs.
        val query = ffmpegQueryExtension.convertVideoToGIF(binding.tvInputPathVideo.text.toString(), outputPath, EncodingQuality.FASTEST)

app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/VideoToGifActivity.kt:61

  • EncodingQuality is hardcoded to FASTEST with no UI to choose other modes; consider exposing a setting or parameter so users can select BALANCED or HIGHEST.
        val query = ffmpegQueryExtension.convertVideoToGIF(binding.tvInputPathVideo.text.toString(), outputPath, EncodingQuality.FASTEST)

app/src/main/res/values/strings.xml:114

  • XML comments must use syntax rather than //; this line will cause a resource parsing error.
    // Time Picker

app/src/main/res/layout/activity_change_audio_valume.xml:1

  • Filename and binding class contain a typo: 'valume' should be 'volume' for consistency.
<?xml version="1.0" encoding="utf-8"?>

@Rajan-p-simform Rajan-p-simform force-pushed the feature/provide-encoding-option branch from d1a98f5 to a24f3f3 Compare July 8, 2025 06:01
@Rajan-p-simform Rajan-p-simform force-pushed the feature/provide-encoding-option branch from a24f3f3 to ec55006 Compare July 15, 2025 11:50
@Rajan-p-simform Rajan-p-simform force-pushed the feature/provide-encoding-option branch from ec55006 to c7fb67e Compare July 15, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant