Add ability to enchant an item at a specific level. #8113
+72
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
requested review from
Efnilite and
Absolutionism
and removed request for
a team
sovdeeth
added
the
enhancement
skriptlang-automation
bot
added
the
needs reviews
Efnilite
approved these changes
Aug 4, 2025
TheLimeGlass
suggested changes
Aug 4, 2025
Absolutionism
approved these changes
Aug 5, 2025
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.13 Releases
skriptlang-automation
bot
added
feature-ready
APickledWalrus
requested changes
Aug 21, 2025
| @Since("2.0") | ||
| @Description("Enchant or disenchant an existing item. Enchanting at a specific level will act as if an enchanting table " + | ||
| "was used, and will apply the enchantments randomly chosen at that level. Treasure enchantments, like mending, can " + | ||
| "optionally be allowed. Note that enchanting a book at a specific level will turn it into an enchanted book, rather " + |
There was a problem hiding this comment.
Is there a way to configure the book behavior?
| }; | ||
| } | ||
| case ENCHANT_AT_LEVEL -> { | ||
| ItemFactory factory = Bukkit.getItemFactory(); |
There was a problem hiding this comment.
minor but can this be grabbed after the levels check?
| } | ||
| case ENCHANT_AT_LEVEL -> { | ||
| ItemFactory factory = Bukkit.getItemFactory(); | ||
| Number levelValue = level.getSingle(event); |
There was a problem hiding this comment.
Could maybe do getOptionalSingle with -1 as the default value:
Suggested change
| Number levelValue = level.getSingle(event); | |
| int level = this.level.getOptionalSingle(event).orElse(-1).intValue(); |
Then you simply check level < 0 as you do now
github-project-automation
bot
moved this from Awaiting Merge
to In Review
in 2.13 Releases
skriptlang-automation
bot
removed
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There was no way of replicating the behavior of the vanilla enchanting table without hardcoding weights and chances manually.
Solution
Adds an option to EffEnchant to use ItemFactory#enchantWithLevels (available on paper 1.20.4+), which gives an itemstack a random set of appropriate enchants based on the given level, identical to the behavior of the enchanting table. I did not add the TagKey-based enchant limiting option as I didn't want to get into implementing the key set system and the only option to do it somewhat nicely seems to be reflection.
Testing Completed
manual confirmation
Supporting Information
Enchanting a book at a level returns an enchanted book instead. Support for those should also be added, but is out of scope of this PR.
Completes: none
Related: none