Fix nullable direction combine #8121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLimeGlass
requested review from
Pesekjak and
Absolutionism
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
Efnilite
requested changes
Aug 10, 2025
Burbulinis
approved these changes
Aug 10, 2025
skriptlang-automation
bot
removed
the
needs reviews
Efnilite
added
the
enhancement
Pesekjak
approved these changes
Aug 11, 2025
Efnilite
approved these changes
Aug 11, 2025
skriptlang-automation
bot
added
the
patch-ready
Absolutionism
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If your syntax has nullable expressions
[%-direction% %-location%]and used directlyexpression = Direction.combine((Expression<Direction>) exprs[0], (Expression<Location>) exprs[1]);it'll throw a null pointer on use.Solution
Rather than having to check if both expressions are null before calling the combine method, you can now properly do the single line call, and the returned expression will be the expected null if the syntax was wanting the expression to be null if not present.
Completes: none
Related: none