Prioritize Skript syntax when parsing #8145
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
requested review from
cheeezburga and
Burbulinis
and removed request for
a team
APickledWalrus
added
the
bug
1 task
Burbulinis
approved these changes
Aug 22, 2025
Absolutionism
approved these changes
Aug 22, 2025
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.12 Releases
Efnilite
approved these changes
Aug 22, 2025
sovdeeth
approved these changes
Aug 22, 2025
skriptlang-automation
bot
added
the
patch-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Parsing order changes are still causing slowdowns, specifically on servers with a significant amount of elements. This is caused by addon syntax being attempted first, even though it is less likely to be used.
Solution
Adds a generally-reliable comparison step for determining if one of the SyntaxInfos is from Skript and the other is not.
Testing Completed
Testing with the user from #8129 confirms the issue is resolved for them.
Supporting Information
n/a
Completes: #8129
Related: none