SCAN4NET-976 Hackathon 2025: Make project.assets.json available in analyzers and java ProjectSensor's #2894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-strecker-sonarsource
changed the title
hashicorp-vault-sonar-prod
bot
changed the title
martin-strecker-sonarsource
changed the title
|
| /// <summary> | ||
| /// Data class to describe a single project configuration for our analyzers. | ||
| /// </summary> | ||
| /// <remarks>The class is XML-serializable. Each change in this class has to be propageted to it's counterpart in sonar-dotnet analyzers.</remarks> |
Contributor
Author
There was a problem hiding this comment.
The changes here, need to be synced also with
https://github.com/SonarSource/sonar-sbom/blob/5dbd5991e5332ca85e30b0524d981f5230dc43bb/frontend/csharp/analyzers/SonarAnalyzer.Sbom.CSharp/Scanner/ProjectConfiguration.cs#L19-L20
| ProjectType = IsTest ? ProjectType.Test : ProjectType.Product, | ||
| TargetFramework = TargetFramework | ||
| TargetFramework = TargetFramework, | ||
| ProjectAssetsFile = ProjectAssetsFile, |
Contributor
Author
There was a problem hiding this comment.
This makes the file path available in the Roslyn analyzer.
| <Value>$(SonarProjectTelemetryFilePath)</Value> | ||
| </SonarQubeSetting> | ||
| <SonarQubeSetting Include="sonar.$(SQLanguage).analyzer.projectAssetsFile" Condition="Exists($(ProjectAssetsFile))"> | ||
| <Value>$(ProjectAssetsFile)</Value> |
Contributor
Author
There was a problem hiding this comment.
This makes the ProjectAssetsFile path available in the Java ProjectSensor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCAN4NET-976