Fix strict TypeScript errors #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

FloEdelmann wants to merge 1 commit into Splidejs:master from FloEdelmann:patch-1

FloEdelmann commented Jul 24, 2024 •

edited

Loading

app.component only allows string as a first parameter: https://github.com/vuejs/core/blob/422ef34e487f801e1162bed80c0e88e868576e1d/packages/runtime-core/src/apiCreateApp.ts#L44

But Splide.name and SplideSlide.name are typed as string | undefined: https://github.com/vuejs/core/blob/422ef34e487f801e1162bed80c0e88e868576e1d/packages/runtime-core/src/componentOptions.ts#L131

So to pass strict TypeScript type-checking, a non-null assertion operator can manually declare that the names are indeed non-nullable (see e.g. a3657c7/src/js/components/Splide/Splide.vue#L26).


          Fix strict TypeScript errors

6a31525

joaogabriel15 approved these changes

View reviewed changes

paw-e-l approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet