Support for new HGETDEL, HGETEX and HSETEX commands #2863
Conversation
- add resultprocessors - fix test fails
|
isn't it duplicate to redis/redis#13577 ? my code has conflict with this @sund. redis/redis#13577 has been reviewed as well |
|
@samanebi ohh, sorry, now this PR is the subset of #13798, we should have set you as the coauther of another PR, so sorry for you. |
It is sad to hear that. thanks for putting me as coauthor of another PR. please let me know about that. thanks |
|
@mgravell @NickCraver , i guess there is flaky test showing up with failed tests: also kind reminder for the PR.. |
|
Hi gents, the PR is pretty old now |
|
I'm currently very much in a "Redis" mode (although I'm focusing on a memory thing right now); I will evaluate this in the coming week (public holiday for the UK today) |
|
I'll take care of the drift/merge, but I might tweak some naming for consistency with the
|
|
more thinking; I think I'll leave the And - we use that other places, think GetSearchAndStore, StreamAcknowledgeAndDelete Still thinking about the AndSetExpiry - overload would seem preferable there |
| } | ||
|
|
||
| // Default case when neither expiry nor persist are set | ||
| return Message.Create(Database, flags, RedisCommand.HGETEX, RedisLiterals.FIELDS, 1, hashField); |
There was a problem hiding this comment.
don't fix (I'm on it), but: missing key here
| @@ -81,6 +81,45 @@ public bool HashDelete(RedisKey key, RedisValue hashField, CommandFlags flags = | |||
| public bool HashExists(RedisKey key, RedisValue hashField, CommandFlags flags = CommandFlags.None) => | |||
| Inner.HashExists(ToInner(key), hashField, flags); | |||
|
|
|||
| public RedisValue HashFieldGetAndDelete(RedisKey key, RedisValue hashField, CommandFlags flags = CommandFlags.None) => | |||
| Inner.HashFieldGetAndDelete(key, hashField, flags); | |||
There was a problem hiding this comment.
needs ToInner on all key usage (I'll do this - I'll read all the pre-existing too; I might write a code-generator for this file!)
… new code, this includes pre-existing bugs: - SetIntersectionLength - SortedSetCombine - SortedSetCombineWithScores - SortedSetIntersectionLength
|
ping @NickCraver @philon-msft for visibility on 1817d93, in particular because of the pre-existing missing usage in
I'll call these out on the release notes, and probably worth a "minor" bump |
This PR adds support for new Redis Hash Commands;
Get and delete the value of one or more fields of a given hash key
Get the value of one or more fields of a given hash key, and optionally set their expiration
Set the value of one or more fields of a given hash key, and optionally set their expiration
Here the implementation consist of sync and async API s for those commands with adding
Leaseversions of them when useful.For more details on commands 👉redis/redis#13798
Redis release including new hash commands 👉https://github.com/redis/redis/releases/tag/8.0-m04