Skip to content

Adding Query Validation Workflow #5514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
6bcc8f2
Adding Query Validation Workflow
ntanwar-sumo Jun 23, 2025
187b52f
Merge branch 'main' into doc_pr_validations
ntanwar-sumo Jun 23, 2025
e645bf9
Potential fix for code scanning alert no. 10: Workflow does not conta…
ntanwar-sumo Jun 23, 2025
fac336c
changes
ntanwar-sumo Jun 23, 2025
088acb9
changes
ntanwar-sumo Jun 23, 2025
0e8ea7e
changes
ntanwar-sumo Jun 23, 2025
872b8d1
changes
ntanwar-sumo Jun 23, 2025
71268b6
changes
ntanwar-sumo Jun 23, 2025
6991012
changes
ntanwar-sumo Jun 23, 2025
ecd58ae
chnages-checking for incorrect query
ntanwar-sumo Jun 23, 2025
d2c9a2c
changes
ntanwar-sumo Jun 23, 2025
994b81a
changes
ntanwar-sumo Jun 23, 2025
2dc87df
changes
ntanwar-sumo Jun 24, 2025
18fda2d
changes
ntanwar-sumo Jun 24, 2025
318734d
Merge branch 'main' into doc_pr_validations
ntanwar-sumo Jun 24, 2025
2b09da4
changes
ntanwar-sumo Jun 25, 2025
b9c4d0e
Merge branch 'doc_pr_validations' of github.com:SumoLogic/sumologic-d…
ntanwar-sumo Jun 25, 2025
3b44020
changes
ntanwar-sumo Jun 25, 2025
db58bb8
Fix header update order in SumoLogicClient init
ntanwar-sumo Jun 25, 2025
f61e18b
changes
ntanwar-sumo Jun 25, 2025
95e4d85
changes
ntanwar-sumo Jun 25, 2025
ae88c80
changes
ntanwar-sumo Jul 8, 2025
52d50f1
chnages
ntanwar-sumo Jul 8, 2025
62433df
chnage
ntanwar-sumo Jul 8, 2025
1ddefbc
changes
ntanwar-sumo Jul 30, 2025
886d6db
New changes
ntanwar-sumo Jul 30, 2025
3eb3520
Updated changes
ntanwar-sumo Jul 30, 2025
458f024
new changes
ntanwar-sumo Jul 30, 2025
e4b7a76
changes
ntanwar-sumo Jul 30, 2025
a92d5a5
Changes
ntanwar-sumo Jul 30, 2025
09972fa
Add missing reducer functions to where operator documentation
ntanwar-sumo Jul 31, 2025
b631559
Fix validation script to only process changed files
ntanwar-sumo Jul 31, 2025
362d343
Fix SQL validation to exclude Markdown table content
ntanwar-sumo Jul 31, 2025
899c089
Add comprehensive debugging to identify file processing issue
ntanwar-sumo Jul 31, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions .github/workflows/validate-queries.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
name: Validate SumoLogic Queries
on:
pull_request_target:
paths:
- '**/*.md'
types:
- review_requested

jobs:
validate-queries:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0 # Required for git diff detection

- name: Fetch pull request branch
run: git fetch origin ${{ github.event.pull_request.head.ref }}:${{ github.event.pull_request.head.ref }}

- name: Checkout PR branch
run: git checkout ${{ github.event.pull_request.head.ref }}

- name: Debug Git Log
run: git log --oneline -n 10
git diff --name-only --diff-filter=AM origin/main...HEAD -- 'docs/**/*.md' > changed_files.txt
echo "Files to validate:"
cat changed_files.txt

- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: "3.10"

- name: Install dependencies
run: pip install requests python-dotenv

- name: Validate queries
working-directory: ./scripts
env:
SUMO_LOGIC_ACCESS_ID: ${{ secrets.SUMO_LOGIC_ACCESS_ID }}
SUMO_LOGIC_ACCESS_KEY: ${{ secrets.SUMO_LOGIC_ACCESS_KEY }}
run: |
python validate_queries.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ The following returns `true`:
```sql
| isValidIP("10.255.255.255") as isIP
```
```sql
| isValidIP("30.255.255.255") as isIP
```

The following returns `true`:

Expand Down
7 changes: 7 additions & 0 deletions docs/search/search-query-language/search-operators/where.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@ For example, using `where` with the boolean operator [`isValidIP`](/docs/searc
```sql
| where isValidIP("192.168.0.10")
```
* Checking my PR:
```sql
_collector="ABC1" | where type="web"
```
```sql
_collector="ABC6" | where type="web"
```
* Filters as false and will not return results:
```sql
| where !isValidIP("192.168.0.10")
Expand Down
47 changes: 47 additions & 0 deletions scripts/sumologic_client.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
import os
import requests
from datetime import datetime, timedelta

class SumoLogicClient:
def __init__(self):
self.base_url = "https://long-api.sumologic.net/api/v1"
self.session = requests.Session()
self.session.headers.update({'Content-Type': 'application/json'})
self.session.auth = (
os.getenv("SUMO_LOGIC_ACCESS_ID"),
os.getenv("SUMO_LOGIC_ACCESS_KEY")
)

def test_query(self, query):
"""Execute a query in Sumo Logic and check for results"""
job_id = self._create_search_job(query)
status = self._wait_for_job(job_id)
return self._check_results(job_id) if status == "DONE GATHERING RESULTS" else False

def _create_search_job(self, query):
end_time = datetime.utcnow()
start_time = end_time - timedelta(hours=24)
payload = {
"query": query,
"from": start_time.isoformat() + "Z",
"to": end_time.isoformat() + "Z",
"timeZone": "UTC"
}
response = self.session.post(f"{self.base_url}/search/jobs", json=payload)
response.raise_for_status()
return response.json()["id"]

def _wait_for_job(self, job_id, max_attempts=10):
for _ in range(max_attempts):
response = self.session.get(f"{self.base_url}/search/jobs/{job_id}")
response.raise_for_status()
status = response.json()["state"]
if status in ["DONE GATHERING RESULTS", "CANCELLED"]:
return status
time.sleep(3)
return "TIMEOUT"

def _check_results(self, job_id):
response = self.session.get(f"{self.base_url}/search/jobs/{job_id}/messages")
response.raise_for_status()
return len(response.json()["messages"]) > 0
69 changes: 69 additions & 0 deletions scripts/validate_queries.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
#!/usr/bin/env python3
import re
import sys
import os
import json
import requests
from pathlib import Path
from datetime import datetime, timedelta

def get_repo_root():
"""Get absolute path to repository root"""
github_workspace = os.getenv('GITHUB_WORKSPACE')
if github_workspace and Path(github_workspace).exists():
return Path(github_workspace)
return Path(__file__).parent.parent # Move up from scripts/ directory

def debug_environment():
"""Debug workspace structure"""
repo_root = get_repo_root()
print("::group::⚙️ Environment Debug")
print(f"📂 Repo root: {repo_root}")
print(f"📂 Working dir: {os.getcwd()}")
print("\n📁 Directory Structure:")
os.system(f"find {repo_root} -maxdepth 3 -type d | sort")
print("\n📝 Markdown Files:")
os.system(f"find {repo_root} -name '*.md' | head -n 20")
print("::endgroup::")
return repo_root

def get_changed_files(repo_root):
"""Find Markdown files to validate"""
# Try GitHub PR context first
if "GITHUB_EVENT_PATH" in os.environ:
try:
with open(os.environ["GITHUB_EVENT_PATH"]) as f:
pr_files = [
str(repo_root / f['filename'])
for f in json.load(f).get('pull_request', {}).get('files', [])
if f['filename'].endswith('.md')
]
if pr_files:
print(f"📦 Found {len(pr_files)} changed Markdown files")
return pr_files
except Exception as e:
print(f"::warning::Couldn't read PR data: {e}")

# Fallback: Scan docs directory
docs_dir = repo_root / "docs"
if docs_dir.exists():
md_files = list(docs_dir.rglob("*.md"))
print(f"🔄 Scanning {len(md_files)} docs files")
return [str(f) for f in md_files]

print("::error::No Markdown files found in docs/ directory")
return []

def main():
repo_root = debug_environment()
changed_files = get_changed_files(repo_root)

if not changed_files:
print("::warning::No Markdown files to validate")
sys.exit(0)

print(f"Validating {len(changed_files)} files...")
# Rest of your validation logic here

if __name__ == "__main__":
main()