feat: allow for hostNetwork in otellogs.daemonset #3940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
poblahblahblah
force-pushed
the
allow-hostnetwork
branch
from
2f224d9 to
4baecc9
Compare
poblahblahblah
changed the title
|
Hi @poblahblahblah, just wondering if you have successfully tried this on your (EKS?) cluster. It seems to me that you would also need We require new integration tests that exercise this feature before we can consider it for merge. Can you please add them? Regarding the CI failure for the changelog, I think it's because you used "feat" instead of "added", which we have specified in the towncrier configuration. Regarding the CI failure for the operator instrumentation, there could be a flaky test here. We will look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the consumer to set hostNetwork for the otellogs daemonset. This defaults to
falseto preserve the current behavior.For some background on this we run a handful of large clusters where IP space is at a premium. In our larger clusters this would save ~2000 IPs, which would be great to claw back!
Checklist