Skip to content

fix(completion): handle empty suffix and inline completion items #4115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lkk214
Copy link

@lkk214 lkk214 commented Apr 4, 2025

Description

Fixed issues with using accept:

  • If the current line has only one suffix, an error will occur when using accept
  • The completion chars may be filtered by dropMinimum in postprocess If there are only a few completion chars at the end
    (Empty items skip the rendering process to be consistent with vscode)

Screenshots

bug0405

Test

fix0405

@wsxiaoys wsxiaoys requested review from icycodes and Copilot April 5, 2025 01:38
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@lkk214 lkk214 marked this pull request as draft April 5, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant