HTM-1651: handle the enablePasswordReset option from the API #1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprins
changed the title
mprins
force-pushed
the
HTM-1651_option_to_disable_password_reset
branch
from
0df13e8 to
4fd584b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for the enablePasswordReset option from the API to conditionally show a "Forgot your password?" link in the login form. The implementation adds the necessary configuration handling, UI components, and internationalization support.
- Added
enablePasswordResetproperty to the login configuration model and component - Implemented conditional display of password reset link in the login form
- Added internationalization support for the "Forgot your password?" text in English, Dutch, and German
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| projects/api/src/lib/models/login-configuration.model.ts | Added enablePasswordReset boolean property to the login configuration interface |
| projects/api/src/lib/mock-data/tailormap-api.mock-data.ts | Updated mock data to include default enablePasswordReset: true |
| projects/core/src/lib/pages/login/login-form/login-form.component.ts | Added property handling and placeholder method for password reset functionality |
| projects/core/src/lib/pages/login/login-form/login-form.component.html | Added conditional password reset link display and improved boolean check |
| projects/core/src/lib/pages/login/login-form/login-form.component.css | Added styling for password reset link container |
| projects/shared/assets/locale/messages.shared.*.xlf | Added translations for "Forgot your password?" in English, Dutch, and German |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
projects/core/src/lib/pages/login/login-form/login-form.component.ts
Outdated
Show resolved
Hide resolved
projects/core/src/lib/pages/login/login-form/login-form.component.css
Outdated
Show resolved
Hide resolved
mprins
force-pushed
the
HTM-1651_option_to_disable_password_reset
branch
from
4fd584b to
98f1d50
Compare
mprins
requested review from
geertplaisier,
matthijsln,
mvdstruijk and
steinkobben
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires Tailormap/tailormap-api#1373 (so the link won't show up until that is merged)