fix: serialize queryKey
#9308
Open
fix: serialize queryKey
#9308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 4cb1669.
☁️ Nx Cloud last updated this comment at |
KATT
commented
Jun 25, 2025
Comment on lines
-1223
to
-1228
| expect(serializeDataMock).toHaveBeenCalledTimes(1) | ||
| expect(serializeDataMock).toHaveBeenCalledWith(0) | ||
|
|
||
| expect(deserializeDataMock).toHaveBeenCalledTimes(1) | ||
| expect(deserializeDataMock).toHaveBeenCalledWith(0) | ||
|
|
There was a problem hiding this comment.
Removed these as the test isn't about whether if serialization is about and the amount of times the mock gets called doubled so it gets a bit weird and unintuitive anyway
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9308 +/- ##
==========================================
- Coverage 45.37% 45.37% -0.01%
==========================================
Files 207 207
Lines 8277 8276 -1
Branches 1862 1868 +6
==========================================
- Hits 3756 3755 -1
Misses 4080 4080
Partials 441 441 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialize query keys
Should fix trpc/trpc#6802