feat: use generic default meta tags unless not overridden #4274

nrjdalal · 2025-05-30T01:09:03Z

packages/react-router/src/HeadContent.tsx
packages/react-router/tests/Scripts.test.tsx

RELEASE_ALL

Currently, none of the packages (i.e `packages/*`) need `vite` bundled as a `dependency`. So its been moved to the `devDependencies` and had the version opened using `"peerDependencies": { "vite": ">=6.0.0" }`. Additionally, `vite` has been added as a `dependency` to the Start end-to-end sandboxes. In a later PR, `vite` will need to be added to all the TanStack Start examples (i.e. `examples/**/start-*`).

…TanStack#4136)

…anStack#4137) Only import `routeCode` if `node.fullPath` is available.

…t + matching server function handler route on Windows (TanStack#4146)

…anStack#4147)

)

…anStack#4149)

…ack#4154)

nx-cloud · 2025-05-30T01:09:27Z

View your CI Pipeline Execution ↗ for commit 2dca19b.

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	✅ Succeeded	1m 3s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2s	View ↗

☁️ Nx Cloud last updated this comment at 2025-05-30 09:16:16 UTC

pkg-pr-new · 2025-05-30T01:11:49Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@4274

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@4274

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@4274

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@4274

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@4274

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@4274

@tanstack/react-router-with-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-with-query@4274

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@4274

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@4274

@tanstack/react-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-plugin@4274

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@4274

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@4274

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@4274

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@4274

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@4274

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@4274

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@4274

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@4274

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@4274

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@4274

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@4274

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@4274

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@4274

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@4274

@tanstack/solid-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-plugin@4274

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@4274

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@4274

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@4274

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@4274

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-client@4274

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-fetcher@4274

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-server@4274

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@4274

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@4274

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@4274

commit: 2dca19b

SeanCassiere

Please export the defaultMeta out of router-core and have them the imported into @tanstack/react-router and @tanstack/solid-router.

Perhaps even have the defaultMeta.forEach(...) bit as a function so the behaviour can be centralized.

nrjdalal · 2025-05-30T01:30:51Z

will make the changes shortly

…s.test.tsx index.ts tanstack... packages/router-core/src/defaultMeta.ts packages/react-router/src/HeadContent.tsx packages/solid-router/src/HeadContent.tsx packages/solid-router/tests/Scripts.test.tsx packages/router-core/src/index.ts examples/react/start-workos/src/tanstack-start.d.ts

packages/router-core/src/defaultMeta.ts

packages/router-core/src/defaultMeta.ts examples/react/start-workos/src/tanstack-start.d.ts

packages/router-core/src/index.ts examples/react/start-workos/src/tanstack-start.d.ts packages/router-core/src/{defaultMeta.ts

SeanCassiere · 2025-05-30T04:46:31Z

@birkskyum would this be the "correct" way to do this for Solid?

SeanCassiere

Looks okay to me. Awaiting @birkskyum's thoughts on this.

…tack#4278)

packages/router-core/src/head-content.ts

packages/router-core/src/head-content.ts examples/react/start-workos/src/tanstack-start.d.ts

birkskyum · 2025-05-30T12:42:24Z

In solid it's called e.g. charset not charSet like react, so the differences in naming have to be accounted for if in core. Changing charSet -> charset is one of the standard things to do when porting from react to solid, same as className -> class

birkskyum · 2025-05-30T12:43:21Z

packages/router-core/src/head-content.ts

+  attrs: Record<string, string>
+}> = [
+  {
+    key: 'charSet',


this is the line specifically i'm thinking won't work with solid

nrjdalal · 2025-05-30T13:57:19Z

In solid it's called e.g. charset not charSet like react, so the differences in naming have to be accounted for if in core. Changing charSet -> charset is one of the standard things to do when porting from react to solid, same as className -> class

it is case insensitive I guess, could always make em small, be that react/solid

could make transformer/matcher

tannerlinsley and others added 30 commits May 10, 2025 14:54

Devinxi (TanStack#4111)

855b03f

fix: RELEASE_ALL

6e5b7a3

RELEASE_ALL

release: v1.20.3-alpha.1

1ceda30

fix: RELEASE_ALL

0b7aefd

RELEASE_ALL

release: v1.120.4-alpha.1

bc2dfa1

fix: clean up Vite versions (TanStack#4130)

e3fd36b

docs(start): Fix contents outdated by Devinxi (TanStack#4125)

82d14bd

release: v1.120.4-alpha.2

c997f90

release: v1.120.4-alpha.3

99a944b

fix(router-generator): exit conditions when using verboseFileRoutes (…

35f6520

…TanStack#4136)

release: v1.120.4-alpha.4

ef337e7

fix(start-plugin-core): patches for Virtual Routes in Server Routes (T…

94400a2

…anStack#4137) Only import `routeCode` if `node.fullPath` is available.

release: v1.120.4-alpha.5

016e5f0

fix(start-plugin-core): include "vite/client" types (TanStack#4139)

20937af

release: v1.120.4-alpha.6

a57676e

fix(start-server-core): appending headers to immutable response objec…

d5c2e6d

…t + matching server function handler route on Windows (TanStack#4146)

ci: apply automated fixes

bef4dab

chore: lint

565c8a0

release: v1.120.4-alpha.7

6542287

refactor(start-server-core): use utility functions from router-core (T…

94c1284

…anStack#4147)

release: v1.120.4-alpha.8

4533d30

docs(start): remove validators from "server routes" guide (TanStack#4148

62a044e

)

fix(start-plugin-core): remove backslashes from declaration import (T…

ac7db71

…anStack#4149)

release: v1.120.4-alpha.9

32f1a8b

feat(router-core): type level parsing of path params (TanStack#4144)

9f63d40

release: v1.120.4-alpha.10

8d4a7e8

docs(start): Server Functions can be called from Server Routes (TanSt…

6bde41f

…ack#4154)

docs(start): server-routes (TanStack#4155)

e6fab6a

docs: update build from scratch

418fac9

SeanCassiere changed the title ~~🔥 feat(meta): use generic default metatags unless not overridden~~ feat: use generic default meta tags unless not overridden May 30, 2025

SeanCassiere requested changes May 30, 2025

View reviewed changes

github-actions bot added package: router-core package: solid-router labels May 30, 2025

autofix-ci bot and others added 4 commits May 30, 2025 02:54

ci: apply automated fixes

44c84cb

chore: tweaks > defaultMeta.ts

550f41f

packages/router-core/src/defaultMeta.ts

chore: tweaks > defaultMeta.ts tanstack-start.d.ts

b8bf45d

packages/router-core/src/defaultMeta.ts examples/react/start-workos/src/tanstack-start.d.ts

ci: apply automated fixes

4c7ded7

nrjdalal requested a review from SeanCassiere May 30, 2025 03:27

nrjdalal and others added 2 commits May 30, 2025 09:23

chore: tweaks > index.ts tanstack-start.d.ts {defaultMeta.ts

862461d

packages/router-core/src/index.ts examples/react/start-workos/src/tanstack-start.d.ts packages/router-core/src/{defaultMeta.ts

ci: apply automated fixes

3563d4b

SeanCassiere requested a review from birkskyum May 30, 2025 04:45

SeanCassiere approved these changes May 30, 2025

View reviewed changes

hiendv and others added 2 commits May 30, 2025 09:25

fix(start-plugin-core): add a defensive check for node.fullPath (TanS…

df8e5cc

…tack#4278)

release: v1.121.0-alpha.21

baef562

schiller-manuel requested changes May 30, 2025

View reviewed changes

packages/router-core/src/head-content.ts Outdated Show resolved Hide resolved

nrjdalal and others added 3 commits May 30, 2025 14:29

chore: tweaks > head-content.ts tanstack-start.d.ts

8c642a0

packages/router-core/src/head-content.ts examples/react/start-workos/src/tanstack-start.d.ts

ci: apply automated fixes

c867bd3

Merge branch 'alpha' into default-meta-tags-if-missing

2dca19b

birkskyum reviewed May 30, 2025

View reviewed changes

schiller-manuel force-pushed the alpha branch 3 times, most recently from 9e45354 to 3cd7e27 Compare August 8, 2025 22:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: use generic default meta tags unless not overridden #4274

feat: use generic default meta tags unless not overridden #4274

Uh oh!

nrjdalal commented May 30, 2025

Uh oh!

nx-cloud bot commented May 30, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented May 30, 2025 •

edited

Loading

Uh oh!

SeanCassiere left a comment

Uh oh!

nrjdalal commented May 30, 2025

Uh oh!

SeanCassiere commented May 30, 2025

Uh oh!

SeanCassiere left a comment

Uh oh!

Uh oh!

birkskyum commented May 30, 2025 •

edited

Loading

Uh oh!

birkskyum May 30, 2025

Uh oh!

nrjdalal commented May 30, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

feat: use generic default meta tags unless not overridden #4274

Are you sure you want to change the base?

feat: use generic default meta tags unless not overridden #4274

Uh oh!

Conversation

nrjdalal commented May 30, 2025

Uh oh!

nx-cloud bot commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SeanCassiere left a comment

Choose a reason for hiding this comment

Uh oh!

nrjdalal commented May 30, 2025

Uh oh!

SeanCassiere commented May 30, 2025

Uh oh!

SeanCassiere left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

birkskyum commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

birkskyum May 30, 2025

Choose a reason for hiding this comment

Uh oh!

nrjdalal commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nx-cloud bot commented May 30, 2025 •

edited

Loading

pkg-pr-new bot commented May 30, 2025 •

edited

Loading

birkskyum commented May 30, 2025 •

edited

Loading

nrjdalal commented May 30, 2025 •

edited

Loading