Add Shelf Framework #10025
Add Shelf Framework #10025
Conversation
| Response _handler(Request request) { | ||
| switch (request.url.path) { | ||
| case 'json': | ||
| return _jsonTest(); |
There was a problem hiding this comment.
nit: Do we prefer to inline the logic over private functions? From some benchmarks I did ages ago, calling a function over inlining introduces a very minimal delay (when done a lot of times). It was quite minuscule though.
There was a problem hiding this comment.
I tried to maintain the same structure as in the pure Dart examples. I wouldn’t expect it to matter since the compiler would likely decide to inline (we can always annotate with @pragma(vm:prefer-inline) if needed).
|
fixes #7493 @felangel @alestiago |
I think we should write idiomatic dart since this aims to be a real world benchmark. Ideally those performance optimizations should be made by the language team 🤷 |
|
@msmith-techempower could you help with a review? 👀 |
|
Sorry, was out on holiday last week... catching up today >_< |
dart-lang/shelf#175
cc @kevmoo @iapicca