Add AE interaction utility class #2866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2866 +/- ##
==========================================
+ Coverage 77.25% 77.26% +0.01%
==========================================
Files 419 419
Lines 22307 22307
Branches 6420 6420
==========================================
+ Hits 17233 17236 +3
+ Misses 3795 3792 -3
Partials 1279 1279 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shlzxjp
reviewed
Jun 10, 2025
exporter/src/aecommand/AECommand.cpp
Outdated
| @@ -28,8 +30,23 @@ AEGP_Command AECommand::PAGPreviewCMD = 0L; | |||
| A_Err AECommand::OnUpdateMenu(AEGP_GlobalRefcon /*globalRefcon*/, | |||
| AEGP_UpdateMenuRefcon /*menuRefcon*/, | |||
| AEGP_WindowType /*windowType*/) { | |||
| A_Err err = A_Err_NONE, err2 = A_Err_NONE; | |||
| "PAG Config...", AEGP_Menu_PREFS, | ||
| AEGP_MENU_INSERT_AT_BOTTOM)); | ||
| ERR(suites.RegisterSuite5()->AEGP_RegisterCommandHook( | ||
| ERR(suites->CommandSuite1()->AEGP_GetUniqueCommand(&exporter::AECommand::PAGConfigCMD)); |
There was a problem hiding this comment.
这些CommandSuiteN，比较多的情况下，最好使用具体的有意义的变量命名。
|
|
||
| void CreateFolder(const std::string& path) { | ||
| if (!fs::exists(path)) { | ||
| fs::create_directories(path); |
There was a problem hiding this comment.
1、需要考虑下父级目录是否存在，需要递归创建下
2、create_directories需要进行异常处理，可以使用如下代码进行异常处理：
std::error_code errorCode;
std::filesystem::create_directories(path, errorCode)
exporter/src/utils/AEHelper.cpp
Outdated
| std::shared_ptr<AEGP_SuiteHandler> AEHelper::Suites = nullptr; | ||
|
|
||
| void AEHelper::SetSuitesAndPluginID(SPBasicSuite* basicSuite, AEGP_PluginID id) { | ||
| Suites = std::make_unique<AEGP_SuiteHandler>(basicSuite); |
There was a problem hiding this comment.
Suites定义为std::shared_ptr，这里需要使用std::make_shared创建
| AEGP_ItemH AEHelper::GetActiveCompositionItem() { | ||
| const auto& suites = GetSuites(); | ||
| AEGP_ItemH activeItemH = nullptr; | ||
| suites->ItemSuite6()->AEGP_GetActiveItem(&activeItemH); |
exporter/src/utils/AEHelper.h
Outdated
|
|
||
| namespace exporter { | ||
|
|
||
| class AEHelper { |
There was a problem hiding this comment.
AEHelper类中全部都是静态成员函数，将class AEHelper该我namespace AEHelper更合适一些
|
|
||
| class AEResourceManager { | ||
| public: | ||
| static bool HasCompositionResource(); |
There was a problem hiding this comment.
类中只有静态成员函数，考虑直接定义成全局函数即可，可以用namespace进行作用域的隔离
jinwuwu001
force-pushed
the
exporter-aeutils
branch
from
c4523a2 to
fb76b5e
Compare
jinwuwu001
force-pushed
the
exporter-aeutils
branch
from
fb76b5e to
1cbbfd3
Compare
shlzxjp
reviewed
Jun 11, 2025
| A_Err err = A_Err_NONE; | ||
| A_Err err2 = A_Err_NONE; |
shlzxjp
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、添加AE工具类
2、添加平台工具类