feature/dedupe #415
Merged
feature/dedupe #415
+145
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add lxml as a requirement for a deduplication script we'll use to reduce deployment size on GitHub. Signed-off-by: Randolph Sapp <rs@ti.com>
Add a script capable of deduplicating assets used between multiple build targets. When attempting to play with sphinx's asset paths I noticed there was a lot of logic around preserving relative links. It didn't seem like they want to allow usage of an asset path outside of the build directory. The WebSupport class seemed to allow some of that flexibility we were looking for, but unfortunately it still assumes the conf.py is in the source directory and has issues working with other Sphinx extensions like ifconfig. Given what we are doing seems to be a niche usecase, we can address this with a little post processing using lxml filters. Signed-off-by: Randolph Sapp <rs@ti.com>
Add a deduplication stage that uses the new dedupe.py script to cut down on duplicated deployment assets. Signed-off-by: Randolph Sapp <rs@ti.com>
StaticRocket
requested review from
VeeruPrudhvi,
aniket-l,
cshilwant,
praneethbajjuri and
uditkumarti
as code owners
|
Some of this logic may be a bit wacky, I was not giving this my full attention. I need to do a proper review tomorrow. |
|
Eh, I think this is still fine for what we're doing here. Ready for other reviews. |
|
@sadik-smd , @aniket-l , @VeeruPrudhvi please review |
praneethbajjuri
approved these changes
Oct 7, 2025
cshilwant
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci(deploy): add a deduplication stage
Add a deduplication stage that uses the new dedupe.py script to cut down on
duplicated deployment assets.
Signed-off-by: Randolph Sapp rs@ti.com
feat(dedupe): add a deduplication script
Add a script capable of deduplicating assets used between multiple build
targets.
When attempting to play with sphinx's asset paths I noticed there was a lot of
logic around preserving relative links. It didn't seem like they want to allow
usage of an asset path outside of the build directory.
The WebSupport class seemed to allow some of that flexibility we were looking
for, but unfortunately it still assumes the conf.py is in the source directory
and has issues working with other Sphinx extensions like ifconfig.
Given what we are doing seems to be a niche usecase, we can address this with
a little post processing using lxml filters.
Signed-off-by: Randolph Sapp rs@ti.com
feat(docker): add lxml as a requirement
Add lxml as a requirement for a deduplication script we'll use to reduce
deployment size on GitHub.
Signed-off-by: Randolph Sapp rs@ti.com
This script can cut our current deployment size down from 1.2 GB to 288 MB in ~30 seconds.