Skip to content

Feature/react 19 #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: next
Choose a base branch
from
Open

Conversation

jonesmac
Copy link

@jonesmac jonesmac commented May 5, 2025

Upgrades the repo to the latest version of react. This includes upgrading the docs package to react 19 which necessitated a next and nextra upgrade as well. It build and deploys but I pulled the repo for the first time so feel to let me know if I missed anything.

If all goes well, I might try to do the MUI upgrade as well.

Copy link

netlify bot commented May 5, 2025

Deploy Preview for any-viewer ready!

Name Link
🔨 Latest commit 1c38b61
🔍 Latest deploy log https://app.netlify.com/sites/any-viewer/deploys/68183c99a5eade00084de70c
😎 Deploy Preview https://deploy-preview-574--any-viewer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

socket-security bot commented May 5, 2025

Copy link

codecov bot commented May 5, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (next@2ce6429). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/components/DataKeyPair.tsx 25.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             next     #574   +/-   ##
=======================================
  Coverage        ?   85.41%           
=======================================
  Files           ?       26           
  Lines           ?     2716           
  Branches        ?      433           
=======================================
  Hits            ?     2320           
  Misses          ?      394           
  Partials        ?        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pionxzh
Copy link
Collaborator

pionxzh commented May 7, 2025

Let me do a detailed test this weekend. Sorry, your PR might need to wait a few days.

@pionxzh pionxzh changed the base branch from main to next May 13, 2025 21:54
@pionxzh
Copy link
Collaborator

pionxzh commented May 13, 2025

Hi, thanks for the work 🙏

I have updated this PR to make it merge into the next branch.

A few feedbacks:

  1. The document migration does not seem to be completed yet.
  • theme.config.js needs to be migrated
  • layout.jsx needs to be further updated to change the name, repo link, etc. And please remove the banner 😂
  • The demo page /full results in a 404.
  1. I saw there is a hydration mismatch error from MUI. I haven't had the time to check the root cause. It's okay that we keep it first.

If all goes well, I might try to do the MUI upgrade as well.

That would be great. I just checked the document and it seems the breaking changes are not too many.

@jonesmac
Copy link
Author

jonesmac commented May 14, 2025

Thanks @pionxzh

I've got some time this weekend to try and wrap this up. I think I can fix the /full going to 404.

theme.config.js needs to be migrated

I've never used the framework for the documentation site so I'm not sure what needs to be done with the theme.config.js. If you can give me some specifics, I don't mind looking in the docs and seeing if I can complete it.

layout.jsx needs to be further updated to change the name, repo link, etc. And please remove the banner 😂

I wonder if that got added by default when I upgraded the dependencies. I can take a look.

@pionxzh
Copy link
Collaborator

pionxzh commented May 15, 2025

Yeah, the layout might be auto generated. They deprecated the config and encourage users to simply put those value into the layout.

I can also help to work on the layout migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants