-
-
Notifications
You must be signed in to change notification settings - Fork 272
glz::json_t trait support #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
StormLord07
commented
Aug 10, 2025
- added a trait support for glz::json_t, map like glaze object jwt::traits::stephenberry_glaze
- and a default.h file
Hi and thank you for showing interest in extending jwt-cpp's support for json libraries. |
@Thalhammer I’ve added tests. Glaze is usually installed via A few points to mention:
|
It should work, unfortunately i cant fix it without changing already exisiting ci too much, its just JWT CI coverage fails on
the fix should be changinx tests CMake file with provding additional args to but
All other problems were mentioned before
tests/traits/StephenberryGlazeTest.cpp:19 |
Using FetchContent is also fine, we already do that for nlohmann json. If you do that it would be good to add a option to disable it so that people can turn it off if they don't want to use it.
That's perfectly fine for me. We don't guarantee/require any support from the json library except whats needed inside jwt-cpp or the trait itself.
Yeah that's known. Coverage broke a while ago due to version changes in githubs runners, I just haven't come around to update it yet. It's outside the scope of the PR, so don't worry about it ;) |