Update Combination.java #6320
Open
Update Combination.java #6320
+25
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The updated code corrects the documentation, simplifies and clarifies the backtracking logic, avoids in-place mutation of the combination set by using a LinkedList<T> during recursion, and constructs new TreeSet<T> instances only for final results to ensure uniqueness and sorted order.
sarthakshelar07
requested review from
DenizAltunkapan,
yanglbme,
vil02,
BamaCharanChhandogi,
alxkm and
siriak
as code owners
|
The updated code corrects the documentation, simplifies and clarifies the backtracking logic, avoids in-place mutation of the combination set by using a LinkedList during recursion, and constructs new TreeSet instances only for final results to ensure uniqueness and sorted order. |
siriak
requested changes
Jun 30, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6320 +/- ##
============================================
- Coverage 74.16% 74.15% -0.02%
+ Complexity 5362 5359 -3
============================================
Files 678 678
Lines 18686 18681 -5
Branches 3625 3623 -2
============================================
- Hits 13858 13852 -6
Misses 4273 4273
- Partials 555 556 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated code corrects the documentation, simplifies and clarifies the backtracking logic, avoids in-place mutation of the combination set by using a LinkedList during recursion, and constructs new TreeSet instances only for final results to ensure uniqueness and sorted order.
clang-format -i --style=file path/to/your/file.java