Numerous significant improvements Beta

ciphers/atbash.py

@@ -3,52 +3,34 @@
 import string
 
 
-def atbash_slow(sequence: str) -> str:
+def atbash(text: str) -> str:
     """
-    >>> atbash_slow("ABCDEFG")
-    'ZYXWVUT'
+    Encodes or decodes text using the Atbash cipher.
 
-    >>> atbash_slow("aW;;123BX")
-    'zD;;123YC'
-    """
-    output = ""
-    for i in sequence:
-        extract = ord(i)
-        if 65 <= extract <= 90:
-            output += chr(155 - extract)
-        elif 97 <= extract <= 122:
-            output += chr(219 - extract)
-        else:
-            output += i
-    return output
-
-
-def atbash(sequence: str) -> str:
-    """
-    >>> atbash("ABCDEFG")
-    'ZYXWVUT'
-
-    >>> atbash("aW;;123BX")
-    'zD;;123YC'
-    """
-    letters = string.ascii_letters
-    letters_reversed = string.ascii_lowercase[::-1] + string.ascii_uppercase[::-1]
-    return "".join(
-        letters_reversed[letters.index(c)] if c in letters else c for c in sequence
-    )
+    The Atbash cipher substitutes each letter with its mirror in the alphabet:
+    A -> Z, B -> Y, C -> X, ... Z -> A (case is preserved)
+    Non-alphabetic characters are left unchanged.
 
+    Args:
+        text: The input string to encode/decode
 
-def benchmark() -> None:
-    """Let's benchmark our functions side-by-side..."""
-    from timeit import timeit
+    Returns:
+        The transformed string
+    """
+    # Create translation tables for uppercase and lowercase
+    lowercase_map = str.maketrans(string.ascii_lowercase, string.ascii_lowercase[::-1])
+    uppercase_map = str.maketrans(string.ascii_uppercase, string.ascii_uppercase[::-1])
 
-    print("Running performance benchmarks...")
-    setup = "from string import printable ; from __main__ import atbash, atbash_slow"
-    print(f"> atbash_slow(): {timeit('atbash_slow(printable)', setup=setup)} seconds")
-    print(f">      atbash(): {timeit('atbash(printable)', setup=setup)} seconds")
+    # Apply both translation mappings
+    return text.translate(lowercase_map).translate(uppercase_map)
 
 
+# Example usage
 if __name__ == "__main__":
-    for example in ("ABCDEFGH", "123GGjj", "testStringtest", "with space"):
-        print(f"{example} encrypted in atbash: {atbash(example)}")
-    benchmark()
+    test_string = "Hello, World! 123"
+    encoded = atbash(test_string)
+    decoded = atbash(encoded)
+
+    print(f"Original:  {test_string}")
+    print(f"Encoded:   {encoded}")
+    print(f"Decoded:   {decoded}")