Don't fail on ID token expiration #168
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevented from reading an expired token from cache and refreshing it. JWT_Exception didn't existed => replaced with UnexpectedValueException used by JWT. Catches ExpiredException and proceeds.
|
I agree that this can be skipped, especially when retrieving token from cache. I don't think that removing this will have any big impact on security of this library, since token for API scenarios is being validated elsewhere. I will walk through the code once more, just to be very sure but I think it should be fine to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevented from reading an expired token from cache and refreshing it.
JWT_Exception didn't existed => replaced with UnexpectedValueException used by JWT.
Catches ExpiredException and proceeds.