Skip to content

Conversation

pronskiy
Copy link
Member

@pronskiy pronskiy commented Aug 15, 2025

Copy link
Contributor

github-actions bot commented Aug 15, 2025

@github-actions github-actions bot temporarily deployed to pull request August 15, 2025 10:49 Inactive
@pronskiy pronskiy requested review from iluuu1994 and Girgias August 15, 2025 10:51
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pronskiy!

There's another reference to "team" below:

Even if it may not be possible to go all the way to full generics, would "compile time-only generics" be a big enough win to justify spending more time on it? Our team thinks it is, but PHP is larger than our team, so we want to get feedback from the broader community.

Though it only says the team thinks it's worth investing more time in, which I don't disagree with.

For some context: I asked Roman whether our team operates on what in Switzerland we call the "principle of collegiality" (i.e. everyone in the team must represent the opinion of the majority to the public). I personally don't think that's a good idea (which I have previously stated for my own RFCs), for the sake of transparency. Given multiple people in the immediate dev-team have voiced some concerns on this approach, I asked Roman whether this is worth clarifying.

@github-actions github-actions bot temporarily deployed to pull request August 15, 2025 12:48 Inactive
@pronskiy pronskiy merged commit e258a55 into ThePHPF:main Aug 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants