Skip to content

Add language strings for GUI:CustomMission and GUI:StartCustomMission #2744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add language strings for GUI:CustomMission and GUI:StartCustomMission #2744

wants to merge 3 commits into from

Conversation

Polypheides
Copy link
Contributor

@Polypheides Polypheides commented Mar 26, 2025 •
edited
Loading

@dmgreeny Add: GUI:CustomMission US, DE, FR, ES, IT, KO, ZH, BP, PL, AR, and RU.
@Polypheides Add: GUI:CustomMission and GUI:StartCustomMission.
@Windstalker Fix: Ukrainian for GUI:CustomMission and GUI:StartCustomMission RU, UK.

xezon
xezon reviewed Mar 26, 2025
View reviewed changes
@dmgreeny dmgreeny added Minor Severity: Minor < Major < Critical < Blocker Text Is text, string, localization related labels Mar 26, 2025
@Polypheides Polypheides requested a review from xezon March 28, 2025 09:07
@Polypheides Polypheides force-pushed the GUI-CustomMission1 branch 3 times, most recently from bbf215d to 8fa892a Compare June 10, 2025 09:36
xezon
xezon reviewed Jun 11, 2025
View reviewed changes
Patch104pZH/GameFilesEdited/Data/generals.str

// Patch104p @fix Polypheides 26/03/2025 added missing 1.05 custom mission menu.

GUI:CustomMission
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only string that Patch 1.05 has added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only string that Patch 1.05 has added?

I can check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untitledstartgame

This Start Game button may be new since GUI:StartGame is not effecting it in my testing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Start Game button may be new since GUI:StartGame is not effecting it in my testing.

Found it its GUI:StartCustomMission @dmgreeny @Windstalker can you provide translations for this entry as well?

Copy link
Contributor

@Windstalker Windstalker Jun 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Polypheides Sure, but in new MRs?
Left a suggestion for a while

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Polypheides Sure, but in new MRs?

Suggestions is enough will add you as co author.

@xezon xezon changed the title Adding GUI:CustomMission Add language strings for GUI:CustomMission Jun 11, 2025
@Polypheides Polypheides changed the title Add language strings for GUI:CustomMission Add language strings for GUI:CustomMission and GUI:StartCustomMission Jun 11, 2025
@Polypheides Polypheides marked this pull request as draft June 11, 2025 19:38
Polypheides and others added 2 commits June 11, 2025 21:44
@Polypheides @Windstalker @dmgreeny
Adding GUI:CustomMission
03da477 
@dmgreeny Add: US, DE, FR, ES, IT, KO, ZH, BP, PL, AR, and RU.
@Polypheides Add: GUI:CustomMission.
@Windstalker Fix: Ukrainian for GUI:CustomMission.

Co-Authored-By: Alex Subota <5517708+windstalker@users.noreply.github.com>
Co-Authored-By: dmgreeny <181935155+dmgreeny@users.noreply.github.com>
@Polypheides
Adding GUI:StartCustomMission
0bccb5d
Windstalker
Windstalker reviewed Jun 13, 2025
View reviewed changes
Windstalker
Windstalker reviewed Jun 13, 2025
View reviewed changes
@Polypheides @Windstalker
Add RU, UK Suggestion
a48e201 
Co-Authored-By: Alex Subota <5517708+windstalker@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xezon xezon xezon left review comments

@Windstalker Windstalker Windstalker approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Minor Severity: Minor < Major < Critical < Blocker Text Is text, string, localization related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Polypheides @xezon @Windstalker @dmgreeny